Skip to content

ci: run integration without waiting for build - #40

Merged
PunGrumpy merged 1 commit into
mainfrom
ci/integration-parallel
Nov 18, 2026
Merged

PunGrumpy merged 1 commit into
mainfrom
ci/integration-parallel

Conversation

@PunGrumpy

@PunGrumpy PunGrumpy commented Nov 18, 2026 •

Copy link
Copy Markdown
Owner

Why

The goal is CI that gives agents and me a result sooner, changing only what the run history supports. On this repo the integration matrix waits for build, though it uses nothing build produces. Integration checks out the repo, runs npm ci, and executes the committed dist/index.mjs.

What changed

needs: build is gone from the integration job, so the three integration legs start alongside build. smoke-test keeps its needs, since it runs only on manual dispatch.

Numbers

Measured from the last 41 green PR runs (GitHub API, script kept with the audit):

p50 p95
PR run, created to last job done 51 s 100 s
Queue wait 2 s 3 s

Windows integration finishes last in 39 of 41 PR runs. Its own work is setup (checkout 5 s, setup-node 5 s, npm ci 7 s) plus a 2 s command, and it starts only after build finishes.

Expected effect, a guess: PR run p50 drops to about 29 s.

How to check it

After merge, compare at least 15 PR runs against the 41-run baseline above. Revert if p50 doesn't drop by at least 10 s.

Left out

  • Pinning third-party actions to commit SHAs: worth doing for the release job's write permissions, but it's hygiene, not speed, and gets its own PR
  • The Bun cache: restore and install cost about the same here (±1 s)
  • Concurrency groups and path filters: no run pairs overlapped (0 of 31), and 2 of 23 commits were non-code
  • The Version Packages PR, where 12 of 13 CI runs ran zero jobs: the fix needs a separate token, which is an owner decision

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Chores
    • Integration checks can now run independently across Ubuntu, Windows, and macOS. This update affects the project’s validation process and does not change the app’s features or behavior.

Integration checks out the repo and runs the committed dist/index.mjs.
It takes no artifact or output from build, so waiting for build only
put Windows integration's setup on the critical path.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@changeset-bot

changeset-bot Bot commented Nov 18, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 0d714c8

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel

vercel Bot commented Nov 18, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
cursor-action Ready Ready Preview Nov 18, 2026 1:11am UTC

@coderabbitai

coderabbitai Bot commented Nov 18, 2026 •

Copy link
Copy Markdown

Explain Change →

No actionable comments were generated in the recent review.

Walkthrough

The CI workflow removes the integration job’s dependency on the build job. The integration job can run independently on Ubuntu, Windows, and macOS.

Changes: CI Job Scheduling

Layer / File(s) Summary
Integration job scheduling
.github/workflows/ci.yml
The integration job no longer waits for the build job.

Estimated code review effort: 1 (Trivial) | ~3 minutes

Change: Other

Merge Risk: Minimal · up to 0d714

This change lets the integration checks start without waiting for the build job. They run the committed distribution file and use no build output, so results should be unchanged and CI should finish sooner. No actionable merge risk remains; the author's plan to measure run times after merge is sufficient.

Pre-merge checks: Passed 4

Check name Status Explanation
Title check Passed The title "ci: run integration without waiting for build" matches the single change in the changeset: the removal of needs: build from the integration job in .github/workflows/ci.yml. It states …
Description check Passed The description explains the why (integration uses the committed dist/index.mjs and does not consume build outputs), the what (needs: build removed from integration, smoke-test keeps its depen…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Title check

Explanation

The title "ci: run integration without waiting for build" matches the single change in the changeset: the removal of needs: build from the integration job in .github/workflows/ci.yml. It states the main change, is concise, and follows the conventional-commit style.

Full details: Description check

Explanation

The description explains the why (integration uses the committed dist/index.mjs and does not consume build outputs), the what (needs: build removed from integration, smoke-test keeps its dependency), measured baseline numbers, a verification plan, and items left out. It does not follow the repository template: the ## Related Issues section (with Closes #&lt;issue_number&gt;), the ## Checklist, the ## Screenshots section, and the ## Additional Notes section are absent. The Description heading is also replaced by ## Why and ## What changed. The checklist items are not applicable to a .github/-only change, but the template expects them to be addressed or marked as skipped. The description is mostly complete on substance, so the check passes, but the template sections should be added.

Resolution

Optionally add the template sections: a ## Related Issues entry (or a note that no issue applies), the ## Checklist with items marked as skipped for a .github/-only change, and ## Screenshots and ## Additional Notes (may state not applicable).

Finishing Touches

Generate unit tests (beta)

  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

A rabbit checks the workflow tree,
The build now runs independently.
On three platforms tests can start,
With fewer waits between each part.
I twitch my nose and hop away.

Recent review info

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 8f3eef9a-262d-4ffe-a05b-471189df3a7e
Commits

Reviewing files that changed from the base of the PR and between 1485a83 and 0d714c8.

Files selected for processing: 1

  • .github/workflows/ci.yml
Files with no reviewable changes: 1

  • .github/workflows/ci.yml

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

Recent review details

Context from checks skipped due to timeout: 2

  • GitHub Check: CodeRabbit
  • GitHub Check: Socket Security: Pull Request Alerts

@PunGrumpy

Copy link
Copy Markdown
Owner Author

Verdict: PASS+NOTES

Head SHA: 0d714c8 (independent read-only verification via gh/jobs API)

  • No hidden dependency: diff is the 2-line needs: build removal on integration. build has no upload-artifact and no outputs:. Integration checks out, runs npm ci --omit=dev, then runs the committed dist/index.mjs. release.yml has no workflow_run or needs on CI, and main has no branch protection or rulesets, so no required-check ordering depends on it.
  • Stale dist: the old needs let a red dist-freshness check hide the integration run. Integration still tests the committed dist, which is what users get, so it stays an honest test of the shipped artifact. A stale-dist PR now shows Build red and Integration green or red on its own merits, and that is accurate because the two checks cover different things. I find that acceptable and not misleading. The cost is wasted Windows and macOS minutes when Build fails early, which is free on this public repo.
  • Head run 44213878788: Build, Docs and all 3 Integration legs were created 01:11:34 and started 01:11:36–37, so none waited for build. Build finished 01:11:57, Ubuntu and macOS integration 01:11:44, Docs 01:12:01 and Windows 01:12:03. All succeeded and Smoke Test was skipped, as expected for a PR. Run wall time was 29 s (n=1 post-change run).
  • Baseline, my own pull of the jobs API: 59 earlier successful PR runs with 3 integration legs, 2026-08-16 to 2026-11-17. Wall time p50 50 s, mean 55.7 s, p95 111 s, min 40 s, max 165 s. The last 15 runs have p50 about 52 s. This is a different cut from the PR's 41-run baseline (51 s / 100 s), but it agrees.
  • Windows integration was the last job in 57 of 59 earlier runs (PR says 39 of 41). It started 2–5 s after build completed in every run, which confirms the serialization. In the head run Windows took about 26 s itself, so the critical path is now Windows at 26 s, with Docs at 25 s and Build at 21 s close behind. The drop is mechanically explained: 29 s versus an earlier min of 40 s and p50 of 50 s.
  • Single-run caveat: n=1 post-change run cannot confirm the p50 drop. The PR's plan to compare at least 15 post-merge runs and revert if p50 doesn't fall by at least 10 s is the right gate. The floor is about 26–29 s, set by Windows setup, so expect p50 around 30 s and not lower.
  • Other checks: CodeRabbit succeeded with no actionable comments, rating merge risk Minimal. Socket (both), GitGuardian, Vercel and Vercel Preview Comments all passed. The changeset-bot "No Changeset" note is correct, since this is CI-only. There are no human or bot review threads.
  • Notes (non-blocking): the PR body says "41 green runs" while the jobs API shows 59 qualifying runs, so state the cut used. Also confirm that smoke-test keeping needs: build is intended: it only runs on manual dispatch, so I agree.

@PunGrumpy
PunGrumpy merged commit c52af63 into main Nov 18, 2026
12 checks passed
@PunGrumpy
PunGrumpy deleted the ci/integration-parallel branch November 18, 2026 01:55

This branch was successfully deployed

1 active deployment
Preview — 0d714c8a Deployed Nov 18, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant