Repository navigation
Fix USB port detection on Linux (3.3.2) - #25
Merged
Merged
Conversation
ubuntu-latest moved to a newer image, and libserialport.so built there needs glibc 2.42 for its termios calls. It loads at the first port scan rather than at startup, so v3.3.1 launches on Ubuntu 24.04 but finds no USB ports. Build on ubuntu-22.04 (glibc 2.35), and fail the Linux jobs if any bundled binary needs more than the runner's glibc.
A scan that throws, as when the serial library can't load, was swallowed and showed "Plug a board in and tap refresh", which sends people to check the cable. Show the underlying error instead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
In v3.3.1 on Linux x64, the port list stays empty and the app says "No USB devices found", even with a board plugged in. Seen on Ubuntu 24.04.
ubuntu-latestmoved to a newer image, andlibserialport.sobuilt there needs glibc 2.42 for its termios calls. It loads at the first port scan rather than at startup, so the app launches normally and the load failure was swallowed byscan(). v3.3.0 needs only glibc 2.33.Changes
ubuntu-22.04(glibc 2.35).check-glibc.sh, which fails either Linux job if a bundled binary needs more than its runner's glibc.Testing
libserialport.so.release.ymlon this branch passed on all platforms, withlibserialport.soneeding glibc 2.33.Not yet run on a real Ubuntu 24.04 machine with a board attached.