Repository navigation
Fix v2 CI: pin Foundry and skip Coveralls outside the main repo - #185
Merged
Merged
Conversation
Forge nightly now checks out the .gitmodules branch for each submodule during `forge install`, which fails on the v0.1.3 tag for lib/create2-helpers. Pin the toolchain to v1.5.1, which keeps submodules at their recorded commits. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Coverage Report for CI Build 40019790333Coverage remained the same at 83.243%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two fixes to
.github/workflows/test.ymlonv2.Run Forge Tests failed at
forge installbecause CI installed the Foundry nightly (forge 1.8.7-nightly). That build checks out thebranchset in.gitmodulesfor each submodule, andlib/create2-helperssetsbranch = v0.1.3, which is a tag. In a shallow Actions checkout the tag isn't present, so it fails withfatal: invalid reference: v0.1.3. This PR pinsfoundry-rs/foundry-toolchaintov1.5.1. With 1.5.1,forge installon a depth-1 submodule checkout exits 0 and leaves every submodule at its recorded commit..gitmodulesand theforge installstep are unchanged.The Coveralls steps in Run Hardhat Coverage and Finish Coverage Results now run only when
github.repository == 'ProjectOpenSea/seadrop'. Forks and mirrors without a Coveralls project skip the upload instead of failing the job.Test plan
🤖 Generated with Claude Code