Skip to content

Revert the sunset notice - #792

Draft
ilicfilip wants to merge 2 commits into
developfrom
filip/revert-sunset-notice
Draft

ilicfilip wants to merge 2 commits into
developfrom
filip/revert-sunset-notice

Conversation

@ilicfilip

Copy link
Copy Markdown
Collaborator

What

Reverts #777 (merge commit 7c18816f). The sunset notice and certificate were only for the final wp.org release (1.10.1), which has shipped. We're still developing the plugin for our other users, and they shouldn't see an end-of-support notice.

Removed:

  • classes/admin/class-sunset-notice.php and its registration in classes/class-base.php
  • The dashboard banner (views/sunset-notice.php) and the plugins-page row notice
  • The certificate view (views/sunset-certificate.php) and its admin-post endpoint
  • The .prpl-sunset-notice CSS in assets/css/admin.css
  • tests/phpunit/test-class-sunset-notice.php

Later PRs checked

I went through #784, #786, #787 and #789. None of them touch the sunset code. The only related change is the 1.10.1 changelog entry in CHANGELOG.md and readme.txt. I kept it on purpose, because it records what that release shipped. Tell me if you'd rather drop or reword it.

The revert applied cleanly with no conflicts. It removes exactly the 6 files #777 changed.

Testing

  • composer check-cs passes at default severity
  • PHPStan passes
  • PHPUnit: 449 tests, all passing
  • With WP-CLI on the local site: the Sunset_Notice class no longer exists, and nothing is hooked on the plugin row, the dashboard header slot or admin_post_prpl_sunset_certificate
  • Not checked in a browser yet: Chrome rejected the local planner.test certificate

🤖 Generated with Claude Code

Reverts #777 (merge 7c18816). The notice and certificate were added
for the final wp.org release (1.10.1), which has shipped. Development
continues for our other users, who should not see an end-of-support
notice.

Removes the Sunset_Notice class, its dashboard and plugins-page notices,
the certificate view and endpoint, its CSS and tests. The 1.10.1
changelog entry stays, since it documents what that release shipped.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

Signed-off-by: Filip Ilic <ilic.filip@gmail.com>
@github-actions

github-actions Bot commented Oct 21, 2026 •

Copy link
Copy Markdown
Contributor

Test on Playground
Test this pull request on the Playground
or download the zip

@github-actions

Copy link
Copy Markdown
Contributor

✅ Code Coverage Report

Metric Value
Total Coverage 33.90% 📉
Base Coverage 34.27%
Difference 📉 -0.37%

⚠️ Coverage below recommended 40% threshold

📊 File-level Coverage Changes (1 files)

📉 Coverage Decreased

Class Before After Change
Progress_Planner\Base 51.59% 48.08% -3.51%
ℹ️ About this report
  • All tests run in a single job with Xdebug coverage
  • Security tests excluded from coverage to prevent output issues
  • Coverage calculated from line coverage percentages

@github-actions

github-actions Bot commented Oct 21, 2026 •

Copy link
Copy Markdown
Contributor

🔍 WordPress Plugin Check Report

⚠️ Status: Passed with warnings

📊 Report

🎯 Total Issues ❌ Errors ⚠️ Warnings
10 0 10

⚠️ Warnings (10)

📁 classes/suggested-tasks/data-collector/class-unpublished-content.php (1 warning)
📍 Line 🔖 Check 💬 Message
103 WordPressVIPMinimum.Performance.WPQueryParams.PostNotIn_post__not_in Using exclusionary parameters, like post__not_in, in calls to get_posts() should be done with caution, see https://docs.wpvip.com/databases/optimize-queries/using-post__not_in/ for more information.
📁 classes/suggested-tasks/providers/class-content-review.php (4 warnings)
📍 Line 🔖 Check 💬 Message
232 WordPressVIPMinimum.Performance.WPQueryParams.PostNotIn_post__not_in Using exclusionary parameters, like post__not_in, in calls to get_posts() should be done with caution, see https://docs.wpvip.com/databases/optimize-queries/using-post__not_in/ for more information.
377 WordPressVIPMinimum.Performance.WPQueryParams.PostNotIn_post__not_in Using exclusionary parameters, like post__not_in, in calls to get_posts() should be done with caution, see https://docs.wpvip.com/databases/optimize-queries/using-post__not_in/ for more information.
381 WordPressVIPMinimum.Performance.WPQueryParams.PostNotIn_post__not_in Using exclusionary parameters, like post__not_in, in calls to get_posts() should be done with caution, see https://docs.wpvip.com/databases/optimize-queries/using-post__not_in/ for more information.
388 WordPressVIPMinimum.Performance.WPQueryParams.PostNotIn_post__not_in Using exclusionary parameters, like post__not_in, in calls to get_posts() should be done with caution, see https://docs.wpvip.com/databases/optimize-queries/using-post__not_in/ for more information.
📁 classes/activities/class-query.php (2 warnings)
📍 Line 🔖 Check 💬 Message
71 PluginCheck.Security.DirectDB.UnescapedDBParameter Unescaped parameter $table_name used in $wpdb->query()\n$table_name assigned unsafely at line 58.
163 PluginCheck.Security.DirectDB.UnescapedDBParameter Unescaped parameter $where_args used in $wpdb->get_results()\n$where_args assigned unsafely at line 153.
📁 classes/suggested-tasks/data-collector/class-yoast-orphaned-content.php (1 warning)
📍 Line 🔖 Check 💬 Message
111 PluginCheck.Security.DirectDB.UnescapedDBParameter Unescaped parameter $query used in $wpdb->get_row()\n$query assigned unsafely at line 98.
📁 classes/suggested-tasks/data-collector/class-terms-without-description.php (1 warning)
📍 Line 🔖 Check 💬 Message
108 PluginCheck.Security.DirectDB.UnescapedDBParameter Unescaped parameter $query used in $wpdb->get_results()\n$query assigned unsafely at line 106.
📁 classes/suggested-tasks/data-collector/class-terms-without-posts.php (1 warning)
📍 Line 🔖 Check 💬 Message
120 PluginCheck.Security.DirectDB.UnescapedDBParameter Unescaped parameter $query used in $wpdb->get_results()\n$query assigned unsafely at line 118.

🤖 Generated by WordPress Plugin Check Action • Learn more about Plugin Check

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant