Repository navigation
Refactor components - #433
Merged
Merged
Conversation
Remove the unreferenced hub Pinia store, leftover mock data in public/analyses.json, the unused next-auth.patch (pnpm-workspace.yaml only applies next-auth-no-proxy.patch), the empty statusTag type module, the unused missing-registry-credentials toast and unused interfaces. Internal-only types are no longer exported. Drop the no-op toast mouse handlers, an unused import and unused CSS rules. Claude-Session: https://claude.ai/code/session_01HyHCR2zAKwwvrasBdDvM2q
Move the ESLint ignore list into its own config object so it applies globally (it previously only scoped the rules block, so .nuxt/.output were linted) and drop paths from another project. Trim boilerplate .gitignore entries for tools this project does not use and ignore .superpowers/. Widen coverage to app/** excluding the generated Api.ts. Remove the explicit api plugin entry from nuxt.config; Nuxt already registers app/plugins/ and resolves the same plugin order without it. Claude-Session: https://claude.ai/code/session_01HyHCR2zAKwwvrasBdDvM2q
…Dependencies Remove chart.js, webpack, sass-loader, @types/uuid, @primevue/forms (still pulled in by @primevue/nuxt-module), @tailwindcss/postcss, tailwindcss-primeui, @vitejs/plugin-vue and @types/eslint-config-prettier; nothing imports or configures them. Move prettier, swagger-typescript-api, globals, sass, tailwindcss and @tailwindcss/vite to devDependencies. proxy-agent stays because the next-auth patch requires https-proxy-agent and proxy-from-env, which only it provides. Claude-Session: https://claude.ai/code/session_01HyHCR2zAKwwvrasBdDvM2q
Move the header, footer and page shell from app.vue into app/layouts/default.vue, leaving app.vue with the global Toast, the loading indicator and NuxtLayout/NuxtPage. Register components without path prefixes so templates use the file name (which is already unique and descriptive), and drop the manual imports of local and PrimeVue components in favour of Nuxt's auto-imports. Move MenuHeader and Footer to components/app/ as AppHeader and AppFooter, move SearchBar to components/shared/, and use NuxtLink instead of vue-router's RouterLink in the header. Claude-Session: https://claude.ai/code/session_01HyHCR2zAKwwvrasBdDvM2q
…bles/ - components/data-stores/create/index.ts -> types/dataStore.ts (Nuxt was registering it as a component called "Create") - flattenLogs moves from types/logs.ts to utils/flatten-logs.ts - connectionErrorToast, useServiceHealth and useIdpHealth contain no Vue/Nuxt context and move to utils/ (connection-error-toast, uptime-slots, idp-health) - the fetch and merge helpers of useProjectAnalysisSummary move to utils/project-analysis-data.ts; the composable stays - useDatastoreRequirement is renamed useDataStoreRequirement to match useDataStoreList - nuxt-auth.d.ts moves to shared/types/next-auth.d.ts, which the app, server and shared tsconfigs all include Tests are moved to mirror the new locations. Claude-Session: https://claude.ai/code/session_01HyHCR2zAKwwvrasBdDvM2q
Pages now own the route-level concerns: the card, title and description text, and reading route params and query. The large page components keep rendering and delegate state to composables, with pure transforms moved to utils/ and unit tested: - AnalysesTable: fetching, caching, pagination and polling move to useAnalyses(); row parsing to utils/analysis-row.ts; filter options, matcher and toggling to utils/analysis-filters.ts. The page passes the description through a slot so the container counter keeps its place. - ProjectsTable: data loading moves to useProjects(), the status meter helpers to utils/project-status-meter.ts. Drop its unused ConfirmDialog. - DataStoreList is folded into pages/data-stores/index.vue (it only wired useDataStoreList to the table); DetailedDataStoreTable's row building moves to utils/data-store-rows.ts. - EventViewer: event fetching and paging move to useEvents(); tag filtering, level counts and formatting to utils/event-format.ts. - DataStoreProjectInitializer: form state and submission move to useDataStoreForm(), project loading to useAvailableProjects(), and helpers to utils/data-store-form.ts. The projectId query is read by the page and passed as a prop. - ContainerLogs takes the analysis and node ids as props from the page. Nothing in app/ imports vue-router directly any more; the 403 page uses Nuxt's useRouter and the global vue-router test mock is gone. Claude-Session: https://claude.ai/code/session_01HyHCR2zAKwwvrasBdDvM2q
Nothing imports vue-router directly any more; Nuxt provides it and its composables. Also exclude the local .playwright-mcp/ output from ESLint. Claude-Session: https://claude.ai/code/session_01HyHCR2zAKwwvrasBdDvM2q
main.css now imports elements, table, preferences and toast CSS, so nuxt.config only lists main.css and the primeicons stylesheet. The selectors in these files are all still used by templates or PrimeVue classes. Claude-Session: https://claude.ai/code/session_01HyHCR2zAKwwvrasBdDvM2q
Closed
|
Important Review skippedToo many files! This PR contains 130 files, which is 30 over the limit of 100. To get a review, reduce the PR to 100 files or fewer by splitting it into smaller PRs or changing its base branch. Upgrade to a paid plan to raise the limit. This review couldn't start because sufficient usage credits or metered capacity aren't available. Add credits or update usage-based reviews in the billing tab, then retry. ⚙️ Run configuration
⛔ Files ignored due to path filters: 1
📒 Files selected for processing: 130
You can disable this status message by setting the
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove several unused components, refactor code, update dependencies