Repository navigation
Update build.ps1 -test -project to be scoped to the project for running tests - #1742
Open
Steve Lee (SteveL-MSFT) wants to merge 2 commits into
Open
Steve Lee (SteveL-MSFT) wants to merge 2 commits into
Steve Lee (SteveL-MSFT) wants to merge 2 commits into
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Empty selections can run all tests, and root-project group intersections are incorrectly rejected.
2 open findings
What changed in this PR
Scopes Pester runs to selected project paths during targeted builds.
Changes:
- Forwards selected projects to the Pester runner.
- Intersects project paths with Pester groups.
- Adds focused Pester tests.
| File | Description |
|---|---|
build.ps1 |
Forwards selected project metadata. |
helpers.build.psm1 |
Applies project and group path filtering. |
tests/helpers.build.pester.tests.ps1 |
Tests Pester path selection behavior. |
🧠 Review effort: Balanced
Give feedback about Copilot approvals in this survey to enter a drawing for a $150 gift card.
Steve Lee (SteveL-MSFT)
changed the title
build.ps1 -test -project to be scoped to the project for running tests
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Code Coverage ReportNo Rust files were changed in this PR. 🔵 Full Codebase Coverage82% (good)
|
Steve Lee (SteveL-MSFT)
requested a review
from Mikey Lombardi (He/Him) (michaeltlombardi)
October 8, 2026 02:58
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
-Testand-Projectare combined, the build currently scopes Rust projects but still runs the full Pester suite. This makes targeted validation unexpectedly expensive.This change forwards the selected project metadata to the Pester runner and uses each project's relative path as the test scope. When
-PesterTestGroupis also supplied, its groups are intersected with the selected project paths so the filters cannot broaden the run.Focused Pester coverage verifies project path selection, group intersection, and incompatible project/group handling.