feat(ui): replace native confirmation dialogs with Compose confirmations - #1129
Merged
Merged
Conversation
lunaynx
approved these changes
Oct 1, 2026
lunaynx
left a comment
lunaynx
left a comment
Contributor
There was a problem hiding this comment.
File picker still needs to be updated since it's fully bricked on 26.3 (Minecraft no longer ships TinyFD) but I'm already looking into that. These changes look fine.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Drops the only uses of the native message dialog, which shouldn't be used in 26.3 and 1.8.9 because SDL can only show them on the main thread, which freezes the game.
Delete profile gets confirmation:
wWaypoints reset button gets a confirm reset:
