Repository navigation
Protocol page: the checker's --probe mode, checking a server, and optional features - #26
Merged
Merged
Conversation
…ional features - Checking a client: the page said the checker cannot see the chunk-summed reward, the terminal observation, the action layout, the connection options or the close handling, and that a client breaking them all prints "no violations". `--probe` with the probe environment (SPEC.md 8.1) and `--scenario basic|resync|text|all` now checks those; the four clauses that stay unchecked, and why, are listed instead. - Checking a server: plugrl-conformance-server, examples/reference_server.py, plugrl-server's CI. - Optional features: protocol version 1 with negotiated features (SPEC.md 10), and reuse-feedback-obs (10.1) with E46's measurement. English and Chinese pages alike.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The protocol page described the checker as it was before
--probe, and it said nothing about negotiated features. This PR brings it up toplugrl-protocol's SPEC.md and README. English and Chinese pages alike.Checking a client
--probe, so the passage is removed.basic,resyncandtextscenarios, which now check the chunk-summed reward, the terminal observation, time-major actions, the connection options and close handling.--probe, and why: from the wire, a correct client and a wrong one look the same.Checking a server (new)
plugrl-conformance-serverand what it checks (§8.2), plusexamples/reference_server.py.plugrl-serverpasses. Its CI runs the server checker on every change; I checked.github/workflows/ci.yml.Optional features (new)
features, as SPEC.md §10 says.reuse-feedback-obs(§10.1). The page gives what it saved in E46 and the checker flags that exercise it.Check: the site's CI (
mkdocs build --strict) on this PR.