Make the RavenDB index wait in the persistence tests tolerant of slow CI runners - #5951
Merged
Merged
Conversation
…ow CI runners The helper waited at most 10 seconds for all indexes to be up to date. A fresh database with three new indexes needed more than that on a Windows runner, which made AuditCountingTests.Should_return_zero_throughput_entry_when_SendOnly fail without any detail about which index was still stale. - Wait up to 60 seconds and poll every 100 ms instead of spinning on a synchronous statistics request - Fail at once when an index is in the error state and include the index errors - Name the stale indexes and their state when the wait times out - Make the helper async and await it at the call sites
ramonsmits
requested review from
mauroservienti
and removed request for
danielmarbach
October 5, 2026 14:35
mauroservienti
approved these changes
Oct 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The persistence tests wait for all RavenDB indexes to be up to date after they write data. The wait gave up after 10 seconds. On a slow Windows runner a fresh database with three new indexes needs more time. This made
AuditCountingTests.Should_return_zero_throughput_entry_when_SendOnlyfail in #5949 with no detail about the cause.Changes to
RavenIndexAwaiterin both RavenDB persistence test projects:The wait returns as soon as the indexes are up to date. The larger budget only adds time when something is wrong.