Repository navigation
Testing nikshay - #159
Testing nikshay#159chetansaroya wants to merge 8 commits into
Conversation
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars.
 |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| */ | ||
| public List<NikshayIdGenerateBeneficiaryDTO> findAllNegativeBeneficiaries() { | ||
| JdbcTemplate jdbcTemplate = new JdbcTemplate(dataSource); | ||
| return jdbcTemplate.query(ALL_NEGATIVE_BENEFICIARIES_SQL, (rs, rowNum) -> mapRow(rs)); |
| + "ORDER BY b.updated_at DESC, b.ben_reg_id DESC LIMIT :size OFFSET :offset"; | ||
| params.addValue("size", size); | ||
| params.addValue("offset", page * size); | ||
| return new NamedParameterJdbcTemplate(dataSource).queryForList(sql, params); |
| MapSqlParameterSource params = new MapSqlParameterSource(); | ||
| String sql = "SELECT COUNT(*) " | ||
| + filteredBeneficiariesSql(phase, status, failedOnly, failureReason, beneficiaryType, search, params); | ||
| Long count = new NamedParameterJdbcTemplate(dataSource).queryForObject(sql, params, Long.class); |
| logger.info("Designated PHI {} {} for village {} by {}", phiId, existing.isEmpty() ? "added" : "updated", | ||
| villageId, createdBy); |
| } | ||
| mapping.setUpdatedBy(updatedBy); | ||
| mapping = transferOutPhiRepo.save(mapping); | ||
| logger.info("Designated PHI mapping {} updated by {}", id, updatedBy); |
| mapping.setStatus(NikshayTransferOutPhiVillageMapping.STATUS_INACTIVE); | ||
| mapping.setUpdatedBy(updatedBy); | ||
| mapping = transferOutPhiRepo.save(mapping); | ||
| logger.info("Designated PHI mapping {} marked inactive by {}", id, updatedBy); |
|
@coderabbitai Please review. |
|
Action not completed
|
|
@CodeRabbit full review |
Action not completed
|
There was a problem hiding this comment.
How does this work?
There is a playwright repo inside a java repo?
| @@ -0,0 +1,55 @@ | |||
| /* | |||
| * AMRIT – Accessible Medical Records via Integrated Technology | |||
There was a problem hiding this comment.
AMRIT – Accessible Medical Records via Integrated Technology
Make this Technologies please.
Across the PR.
There was a problem hiding this comment.
@chetansaroya is this really needed? Can't we send login requests directly from Java?
| throw new IllegalArgumentException("cron must be a Spring expression (second minute hour day month weekday)"); | ||
| } | ||
| scheduleRepository.save(enabled, cron, updatedBy); | ||
| logger.info("Ni-kshay job schedule set to enabled={} cron='{}' by {}", enabled, cron, updatedBy); |
|
@coderabbitai review |
Action not completed
|
|
Addressed JS call for login with Java. |
|
|
@chetansaroya LGTM. There are some open security issues. |
📋 Description
JIRA ID: STOP-647