Repository navigation
ocl-load-test: build under a local-only image name - #784
Merged
Merged
Conversation
The test build was tagged partnersinhealth/zl-emr:latest, replacing a developer's local copy of the published image with a build of the test export. Build it as ocl-load-test/zl-emr:<instance> instead, and remove it at the end. initialize needs the image before the build (to find the user that owns openmrs-data), so the published image is tagged under the test name first. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #783, which merged before this fix was pushed.
scripts/ocl-load-test.shbuilt the test distribution aspartnersinhealth/zl-emr:latest. On GitHub runners that doesn't matter, but when the PIH "ocl" Claude skill runs it on a developer machine, it replaced their local copy of the published image with a build of the test export.Now:
ocl-load-test/zl-emr:<instance>, a local-only name, and removes that image at the end.initializeneeds the OpenMRS image before the build, to find the user that ownsopenmrs-data. So the script first tags the publishedpartnersinhealth/zl-emr:latestunder the test name. The two images run as the same user, and the build replaces the tag.Tested locally with 1.8.56: it passed,
partnersinhealth/zl-emr:latesthad the same image ID before and after, and the test image was removed.🤖 Generated with Claude Code