Repository navigation
ocl: general release check (ocl_release_check.py) for the skill and CI - #8
Merged
Merged
Conversation
…I (UHM-9643, UHM-9656) Replaces check_clone_mappings.py with ocl_release_check.py: named, pluggable checks (name-uuids, clone-mappings), error/warning severities, --export/--baseline for CI, --fail-on, --summary-md and exit codes. Adds unit tests and a workflow that runs plugin script tests. Docs updated; plugin 0.4.0. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
3 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Turns the OCL clone check into a general release check that can be added to over time, and makes it usable in CI. The PIH/pihemr "Update OCL export" Action (UHM-9643, PIH/pihemr#769) will download it from
mainand run it on each new export before opening a PR.Changes
scripts/ocl_release_check.pyreplacescheck_clone_mappings.py. Checks are registered by name inCHECKS, so they can be added or retired one at a time (--list-checks):name-uuids(UHM-9656): name uuids that clash with a PIH DB snapshot (incl. voided names), or are shared by two PIH concepts. Known clashes that are already fixed on servers (HANDLED_NAME_CLASHES, e.g. the 21797 PAS name freed by pihemr#776) are reported as warnings.clone-mappings(UHM-9636, ocl_issues#3012/#3013): the same logic as before, including the OCL fix watch.error(the import will fail, or wrong data reaches servers) orwarning(OCL-only).--unreleased [--since V]: the pre-release check, as before.--concept …: specific concepts, live.--export NEW [--baseline OLD]takes an export zip or JSON. With a baseline, it only checks the concepts that changed.--fail-on error|warning|never,--summary-md FILE, and exit status 0 OK / 1 findings / 2 couldn't run. The token can come from$OCL_API_TOKEN.test_ocl_release_check.pyhas 9 tests, with no network needed..github/workflows/test-scripts.yml: runs all plugin script tests on PRs and onmain. This protects the options the pihemr Action relies on.Testing
check_updateand the release check).--unreleasedon the live source (169 concepts changed since 1.8.50, the DICOM work) finds only warnings and exits 0.--concept 21797now reports the clash as handled (a warning), since pihemr#776 fixes it on servers.🤖 Generated with Claude Code