Repository navigation
Conversation
Recognize numeric-leading footnote definitions and retain smaller multiplication operators, so the November 2007 SEC PDF's note 12 does not absorb note 13. Add a targeted regression test for page 173. Co-authored-by: Codex Web <noreply@openai.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
In the SEC's November 2007 Commission voting archive, PDF page 173, highlighting footnote 12 also highlights footnote 13. Note 13 starts with the calculation
6.63 脳 800 = 5,304, rather than alphabetic text. The footnote indexer's adjacent-text check only accepted letters, so it could skip the next marker and absorb its text into note 12.Fix
Verification
main: one commit ahead, zero behind, withsrc/viewer/navigation/footnote-index.jsandtests/footnote-click-copy.test.mjschanged.npm testand verify clicking/highlighting note 12 and note 13 separately on the source PDF.Related work