Repository navigation
Conversation
Consume Chrome's connection error in the PDF summary port's disconnect handler, release its timer, and reject pending acknowledgements without leaving a stale resolver. Co-authored-by: Codex Web <noreply@openai.com>
Add a regression case that simulates a failed viewer connection and verifies that the disconnect callback consumes Chrome's runtime error. Co-authored-by: Codex Web <noreply@openai.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Chrome can report
Unchecked runtime.lastError: Could not establish connection. Receiving end does not exist.when the viewer's PDF-summary port disconnects without an available receiving listener. The viewer's disconnect callback did not readchrome.runtime.lastError, leaving that failure unconsumed.Change
chrome.runtime.lastErrorsynchronously in the summary port's disconnect handler.Scope and verification
mainin the intended viewer and test files.src/viewer.html:0alone does not identify the initiating extension script; if the warning persists without using Summarize with ChatGPT, other extension messaging sources should be investigated.