Skip to content

๐Ÿ–Œ๏ธ Streamline PDF viewer tools menu - #199

Merged
JFWooten4 merged 2 commits into
mainfrom
refine-viewer-tools-menu-20261018
Oct 18, 2026
Merged

JFWooten4 merged 2 commits into
mainfrom
refine-viewer-tools-menu-20261018

Conversation

@JFWooten4

Copy link
Copy Markdown
Member

Summary

  • Remove the standalone footnote-number form from the PDF viewer tools menu; keep inline reference jumps and provide toast feedback for lookup failures.
  • Remove the duplicate Show minimap setting, relying on the dedicated collapse/expand control. Convert legacy pdf-viewer-show-minimap=false into an initially collapsed (but re-expandable) minimap, and expand it when numbered page tabs are enabled.
  • Move Show printed-page search directly below Footnote cross-references.
  • Insert a horizontal separator before Relative dates.
  • Remove obsolete footnote-form CSS and update the menu and minimap regression tests.

Verification

  • Verified that the branch is one commit ahead of main with six intended changed files and no unrelated changes.
  • Reviewed the commit diff and added tests for the control removal, menu ordering, legacy minimap behavior, and the page-tabs opt-in path.
  • Tests were not run locally; the repository's GitHub Actions build should validate the PR.

JFWooten4 and others added 2 commits October 18, 2026 05:24
Remove the standalone footnote field and duplicate minimap visibility setting, place printed-page search alongside cross-references, and separate relative date preferences. Retain inline footnote navigation and migrate the legacy minimap visibility preference to its collapsible control, with regression coverage.

Co-authored-by: Codex Web <noreply@openai.com>
Replace expectations tied to the removed footnote form and minimap visibility checkbox with coverage for inline footnote navigation, toast errors, and preserved thumbnail behavior.

Co-authored-by: Codex Web <noreply@openai.com>
@JFWooten4
JFWooten4 merged commit b1ac363 into main Oct 18, 2026
1 check passed
@JFWooten4
JFWooten4 deleted the refine-viewer-tools-menu-20261018 branch October 18, 2026 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant