Repository navigation
Added projector sable compat - #132
sculpted-code wants to merge 205 commits into
Conversation
0a32084 to
ad47c5c
Compare
|
I've moved some logic to SableCompat util. Didn't noticed util at first |
| return SableCompanion.INSTANCE.distanceSquaredWithSubLevels(level, first, second); | ||
| } | ||
|
|
||
| public static double distanceRectilinear(Level level, Vec3 first, Vec3 second) { |
There was a problem hiding this comment.
yeah, i should've named it distanceTo...
|
So this PR can stay open, but all of the files you're modifying no longer exist locally. I've got ~1,120 files pending a big commit that moves about 95% (so far) of the mod from Scala to Java. Once that's done, I'll review this, and you can either update it to Java, or I can take your Scala and merged it into the Java rewrite. I appreciate the PR, it's a neat feature. |
|
Yes, i would love to move code to Java, considering size of changes pr makes, it should be easy But while i am on it, i could try fixing all Sable related issues, holoscreens and holograms(wich do not render correctly even in world) as an example |
|
Apparently, you can't draft pr with gh mobile |
|
Ok, the Java rewrite is done, so you're good to go whenever. |
591bd0e to
e20e05a
Compare
|
Manually merged in |
Bug fixes:
New featurest: