Repository navigation
Compatibility "fix" on Robots & co. swinging - #131
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Technically, this code isn't explicitly necessary according to NeoForge API, but the absence of this passing of Direction caused an issue in Kritter (API used by Cynosure) which expects said
@Nullableto be not null.Since there is no reason (to my knowledge) to not pass this information when we already have it 1 class up, I suggest doing so.
Issue occurs on OC:R (2d0bccc - latest) with Cynosure 1.0.3, and has already been reported to Kritter aswell.