Skip to content

fix(events): stop logging hydration rows that getAllByPage's own joins produce - #645

Open
romanetar wants to merge 2 commits into
mainfrom
fix/get-all-by-page-hydration-warnings
Open

romanetar wants to merge 2 commits into
mainfrom
fix/get-all-by-page-hydration-warnings

Conversation

@romanetar

@romanetar romanetar commented Oct 19, 2026 •

Copy link
Copy Markdown
Collaborator

ref: https://app.clickup.com/t/86bchmbde

Summary

  • `DoctrineSummitEventRepository::getAllByPage()` selects `Presentation p` and `PresentationType et2` through `JOIN ... WITH` (joins on columns). Doctrine returns those as extra elements of the result, or `null` when the join finds no row.
  • The indexing loop already skipped them correctly, but logged an `unexpected hydration row` WARNING for each one (40K-69K lines per business day in prod).
  • Now `null` and `PresentationType` elements are skipped without logging; any other element still logs the warning. Returned events and order are unchanged.

Test plan

  • New `EventsHydrationRowWarningTest` (tests/Repositories): fails on the old code with 42 warnings, passes with the fix; asserts every fixture event is returned in page order
  • Full `tests/Repositories` suite passes (44 tests)
  • After deploy, Loki `{service_name="summit-api", k8s_cluster_name="prod-fn", container="summit-api-php"} |= "unexpected hydration row"` returns no lines over 7 days

@coderabbitai

coderabbitai Bot commented Oct 19, 2026

Copy link
Copy Markdown

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration
  • Configuration used: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 771499a2-c92d-4222-a559-4bfccaabde04
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

Copy link
Copy Markdown

📘 OpenAPI / Swagger preview

➡️ https://OpenStackweb.github.io/summit-api/openapi/pr-645/

This page is automatically updated on each push to this PR.

@romanetar
romanetar requested a review from smarcet October 19, 2026 14:27

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant