Repository navigation
chore(mysql): upgrade CI and local docker to MySQL 8.4 - #179
Conversation
Bump the mysql service images in the GitHub workflows and docker-compose.yml from 8.0 to 8.4. MySQL 8.4 removed --default-authentication-plugin and disables mysql_native_password by default, so the local compose command now uses --mysql-native-password=ON.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
📝 Walkthrough
Merge Risk: ⚪ Minimal · up to
|
| Check name | Status | Explanation |
|---|---|---|
| Description Check |  |
Check skipped - CodeRabbit’s high-level summary is enabled. |
| Title check | |
The title clearly and concisely describes the main change: upgrading MySQL to 8.4 in CI and the local Docker setup. |
| Docstring Coverage | |
No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0… |
| Linked Issues check | |
Check skipped because no linked issues were found for this pull request. |
| Out of Scope Changes check | |
Check skipped because no linked issues were found for this pull request. |
Full details: Docstring Coverage
-
Explanation
No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (5 skipped: 5 unsupported.)
✨ Finishing Touches
-
🧪 Generate unit tests (beta)
-
- Commit to this branch
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands.
|
📘 OpenAPI / Swagger preview ➡️ https://OpenStackweb.github.io/openstackid/openapi/pr-179/ This page is automatically updated on each push to this PR. |
There was a problem hiding this comment.
🟢 Approval recommended
The configuration changes are consistent with the upgrade, with no blocking issues identified.
No open issues 🎉
What changed in this PR
Upgrades CI and the local Docker stack to MySQL 8.4 LTS.
Changes:
- Updates MySQL images from 8.0 to 8.4 across four workflows and Docker Compose.
- Replaces the removed authentication flag with
--mysql-native-password=ONlocally.
| File | Description |
|---|---|
docker-compose.yml |
Upgrades MySQL and replaces the authentication flag. |
.github/workflows/push.yml |
Uses MySQL 8.4 for push CI. |
.github/workflows/pull_request_unit_tests.yml |
Uses MySQL 8.4 for PR tests. |
.github/workflows/nightly_unit_tests.yml |
Uses MySQL 8.4 for nightly tests. |
.github/workflows/l5-swagger-generate.yml |
Uses MySQL 8.4 for Swagger generation. |
Review effort: Balanced
ref: https://app.clickup.com/t/9014802374/86bc4fgv6
Summary
Upgrade MySQL from 8.0 to 8.4 (LTS) in GitHub Actions and in the local docker stack.
push.yml,pull_request_unit_tests.yml,nightly_unit_tests.ymlandl5-swagger-generate.yml: themysqlservice now usesmysql:8.4.docker-compose.yml:dbnow usesmysql:8.4.docker-compose.yml: MySQL 8.4 removed--default-authentication-plugin(the server refuses to start with it) and disablesmysql_native_passwordby default, so the command now passes--mysql-native-password=ONinstead.Notes
Tests
mysql:8.4with the exact flags fromdocker-compose.yml: server reports 8.4.x and accepts connections.