Repository navigation
feat(webserver): map UX improvements - #67
Merged
Merged
Conversation
- Larger click tolerance for CML lines (canvas renderer) - Metric scale bar on map - Show length, frequency and polarization in map popup - Default Grafana refresh 1m - Document remaining UI/UX suggestions
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #67 +/- ##
==========================================
+ Coverage 85.78% 86.65% +0.86%
==========================================
Files 41 37 -4
Lines 3911 3424 -487
==========================================
- Hits 3355 2967 -388
+ Misses 556 457 -99
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
…ale bar - Highlight selected CML on user and admin maps - Admin map: metadata popup, opens when CML chosen in Grafana dropdown - Scale bar next to zoom buttons (user and admin map)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Map UX improvements
First batch of low-effort items from user feedback (backlog for the rest:
docs/ui-ux-improvements.md).Changes
/api/cml-mapand/api/admin/cml-mapnow returnlengthandsublinks.cml-realtime,cml-admin-realtime) and iframe URLs.Notes
cml_metadata.lengthis in metres andfrequencyin MHz (as in the archive CSV). Theother_mno_csvparser mapslength_kmdirectly, so that source may need normalising.docs/ui-ux-improvements.mdlists remaining suggestions with effort estimates.Testing
pytest webserver/tests: 119 passed, 1 skipped; CI green.