[lokewate]

Note

For reviewers, lines to review (blank lines not counted): code +29 / −2, plus 28 / −3 comment lines · tests +121 / −2 · docs +4 / −2. Diff against #287.

Summary

Add store.StateOnHold ("ON_HOLD") and a seq-guarded HoldTask write so a task row moves to ON_HOLD whenever a node in its workflow parks for admin intervention, stripping interactive actions and refusing drafts until an admin resolves the park.

Type of Change

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• Documentation update
• Refactoring (no functional changes)
• Performance improvement
• Other (please describe):

Changes Made

• workflow: Add Seq int64 to AdminParkPayload and populate it from nodeInfo.Seq in notifyAdminPark so hosts can order park notifications against later step claims.
• taskflow/store and taskflow/store/gorm: Add StateOnHold = "ON_HOLD" and TaskStore.HoldTask(ctx, taskID, seq), guarded by (seq <= ? OR (state = 'ADVANCING' AND seq = ? + 1)) AND state NOT IN ('COMPLETED', 'CANCELLED'), and include StateOnHold in WriteDraft's excluded states.
• taskflow/orchestrator: Add TaskManager.HoldTask(ctx, payload) to wire to a task workflow runner's AdminParkHandler, and refuse StateOnHold in SaveDraft.
• A step that parks after its submission (for example, a required output is missing) is held too: PersistSubmission has already moved the row to ADVANCING at seq + 1, so HoldTask also accepts that row and keeps seq + 1, so a repeated submission of the step stays stale. Tested in TestHoldTask_StepParkedAfterItsSubmission and TestHoldTask_HoldsAStepThatParkedAfterItsSubmission.
• taskflow/docs/architecture.md: Document HoldTask and ON_HOLD lifecycle semantics.

Testing

• I have tested this change locally
• I have added tests that prove my fix is effective or that my feature works
• I have tested edge cases
• All existing tests pass

Checklist

• My code follows the project's style guidelines
• I have performed a self-review of my code
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• My changes generate no new warnings
• I have checked that there are no merge conflicts

Related Issues

Related to https://github.com/LSFLK/lsf-govtech-tnsw/issues/243
Stacked on #287

Screenshots/Demo

N/A

Additional Notes

Stacked on #287 (feat/task-cancel-and-fail-activation). TaskStore gains HoldTask(ctx, taskID, seq).

[coderabbitai]

Important

• 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

Run configuration

• Source mode: Auto
• Repository: Unavailable
• Branch: Unavailable
• File: No configuration file from this repository applied
• Commit: Unavailable
• Layers: defaults
• Review profile: CHILL
• Plan: Advanced
• Run ID: f817289f-e039-4dcd-9fcd-7c5f608ac995

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[Aravinda-HWK]

LGTM