Repository navigation
fix duplicated hid - #53
Merged
Merged
Conversation
|
Caution Review failedThe pull request is closed. Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
ApprovabilityVerdict: Approved at Macroscope's review found this PR approvable — This is a localized HID enumeration fix that groups serial-less Windows collections correctly and refreshes open devices when their paths change. Its runtime impact is confined to HID discovery and recovery, with no schema, deployment, security, authentication, or billing changes. Notes:
You can add or adjust custom eligibility rules. Learn more. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix duplicated HID devices by grouping on serial or collection interface
HidSessiondevice listing now compares each candidate's stored paths with the current path set. If they differ, it re-inspects the candidate, or callsrecoverwhen the device is open.grouped_device_keyin hid.rs now prefers a non-empty serial, then a parsed collection interface (via the newcollection_interfacehelper for\?\hid#paths), and falls back to the original path.inspect_candidateno longer rejects multi-path candidates that lack a shared verified serial; theshares_verified_serialhelper and its test are removed.Macroscope summarized 9825735.