Skip to content

fix duplicated hid - #53

Merged
7eedle merged 4 commits into
release/v1.0.0-beta.21from
main
Oct 27, 2026
Merged

7eedle merged 4 commits into
release/v1.0.0-beta.21from
main

Conversation

@7eedle

@7eedle 7eedle commented Oct 27, 2026 •

Copy link
Copy Markdown
Contributor

Fix duplicated HID devices by grouping on serial or collection interface

  • HidSession device listing now compares each candidate's stored paths with the current path set. If they differ, it re-inspects the candidate, or calls recover when the device is open.
  • grouped_device_key in hid.rs now prefers a non-empty serial, then a parsed collection interface (via the new collection_interface helper for \?\hid# paths), and falls back to the original path.
  • inspect_candidate no longer rejects multi-path candidates that lack a shared verified serial; the shares_verified_serial helper and its test are removed.
  • Behavioral Change: devices with the same vendor/product IDs and a matching collection interface now group together even without a serial, in hid.rs.

Macroscope summarized 9825735.

@github-actions github-actions Bot added area: native Native bridge and platform services area: devices HID access and device drivers labels Oct 27, 2026
@coderabbitai

coderabbitai Bot commented Oct 27, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Caution

Review failed

The pull request is closed.

Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@7eedle
7eedle merged commit 8273fe6 into release/v1.0.0-beta.21 Oct 27, 2026
10 of 11 checks passed
@macroscopeapp

macroscopeapp Bot commented Oct 27, 2026

Copy link
Copy Markdown

Approvability

Verdict: Approved at 9825735

Macroscope's review found this PR approvable — This is a localized HID enumeration fix that groups serial-less Windows collections correctly and refreshes open devices when their paths change. Its runtime impact is confined to HID discovery and recovery, with no schema, deployment, security, authentication, or billing changes.

Notes:

  • Your repo's Minimum Blocking Severity is Off, so correctness findings do not automatically block approval.
  • All code in this push has already been reviewed. Approvability was decided on eligibility alone.

You can add or adjust custom eligibility rules. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: devices HID access and device drivers area: native Native bridge and platform services

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant