Repository navigation
CMake: only auto-load vcpkg toolchain for standalone builds - #1
Draft
LimitlessGreen wants to merge 1 commit into
Draft
LimitlessGreen wants to merge 1 commit into
LimitlessGreen wants to merge 1 commit into
Conversation
4 of 6 tasks
The VCPKG_ROOT toolchain hook now applies only when devourer is the top-level project and no CMAKE_TOOLCHAIN_FILE was given. Under add_subdirectory it never took effect, and a parent (e.g. OpenHD's windows-ground preset) owns the toolchain choice.
LimitlessGreen
force-pushed
the
feature/vcpkg-windows
branch
from
October 23, 2026 17:32
d7a5f22 to
65e4206
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
VCPKG_ROOTtoolchain hook now only applies when devourer is the top-level project and noCMAKE_TOOLCHAIN_FILEwas given.add_subdirectorythe hook never had an effect anyway; the parent project owns the toolchain. OpenHD's newwindows-groundpreset sets the vcpkg toolchain itself.WIN32-guarded).Part of moving the OpenHD Windows ground build to vcpkg, see the OpenHD PR on branch
feature/vcpkg-windows.Test plan
windows-groundpreset (MinGW, vcpkg, static): configure, build, 5/5 ground tests