Repository navigation
Conversation
"text" is in SIZE_CHECK_TYPES, and the size check returned before the Text file-name check, so that check never ran and every small Text file was kept whatever its name. Reject large files first and then apply the file-type rules, so Text files get both checks. Fixes OpenDCAI#574
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CodeFileTypeContentFilterdocuments a file-name rule for Text files (keep README/notes/todo/description/CMakeLists and requirements files), but"text"is also inSIZE_CHECK_TYPES, and the size check returned first in theif / elifchain. So_is_text_filename_valid()never ran, and every Text file under 512 lines was kept whatever its name (e.g.random_dump.txt).Fix
Reject large files first, then apply the per-type rules, so Text files get both the size check and the file-name check. JSON/YAML/other size-checked types and HTML behave as before.
Tests
Added
test/cpu_only/test_code_file_type_content_filter.py:random_dump.txtkept), passes after.Fixes #574