Repository navigation
App Bundle next to the APK, staging version code, Play requirement checks - #256
Merged
Merged
Conversation
…t, Play checks (OpenClapper-dev/deploy#10) Build APK's release and staging runs also build bundleRelease and upload the .aab as a second artifact, checked for the debug key like the APK. The staging app's versionCode is the commit count (GIT_COMMIT_COUNT from a full checkout; the build fails on a shallow one), so every build of main is a new version for Play. A "Play requirements" step reads the APK: target API level below 36 fails the run; native libraries not aligned to 16 KB are reported as a warning. self-hosting.md gets a Play Store section, releasing.md the version-code rules and the downgrade trap. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of OpenClapper-dev/deploy#10 (epic deploy#8, Play Store). Closed by hand on merge.
What changed
releaseandstagingruns) also runsbundleReleaseand uploads the.aabas a second artifact (openclapper[-staging]-<version>-<commit>.aab). It is checked for the debug key like the APK, withjarsigner. Dev runs are unchanged.APP_VARIANT=stagingtakesGIT_COMMIT_COUNT(set by the workflow fromgit rev-list --count HEAD). A staging build from a shallow checkout fails, because the count would be 1. Without the variable, a local config run falls back to the release scheme. Production keeps the release scheme.aapt2:LOADalignment with the NDK'sllvm-readelf. A library below 16 KB is a warning plus a line in the summary for now, because no real build has been checked yet.self-hosting.mdgets a "Play Store" section (bundle, requirements, version codes, signing choice, the first upload by hand).releasing.mdgets the version-code rules and the downgrade trap of sideloaded branch builds.Checked
make check.expo configwithAPP_VARIANT=staginggivesorg.openclapper.stagingwithversionCode371 whenGIT_COMMIT_COUNT=371, and 10000 without it. Production stays 10000 with the variable set.aapt2parsing and the hex alignment comparison were checked against sample output.Not checked
main. It will show the target level and the 16 KB result.🤖 Generated with Claude Code