Skip to content

fix(renderer): keep the whole-row write for widths the cell delta cannot model - #7

Merged
jiunbae merged 2 commits into
mainfrom
sync/upstream-pr-branches
Oct 18, 2026
Merged

jiunbae merged 2 commits into
mainfrom
sync/upstream-pr-branches

Conversation

@jiunbae

@jiunbae jiunbae commented Oct 18, 2026

Copy link
Copy Markdown
Member

Two commits:

Tests: rmux-server pane_delta / popup_delta / live_render tests (49) pass on Windows 11, including a new test with every failing case from the review; cargo clippy -p rmux-server --all-targets -- -D warnings and cargo fmt --check pass.

🤖 Generated with Claude Code

Splitting the fork's popup and renderer work into upstream pull requests
(Helvesec#233, Helvesec#234, Helvesec#235) added a regression test for a session
switch made from inside a popup, sorted the unicode-width dependency, and
replaced private names in a test fixture.

Signed-off-by: Jiun Bae <jiunbae.623@gmail.com>
…not model

The styled-row cell delta measured cells with plain unicode-width, while
the server's grid uses rmux-core's model: its emoji override table, ZWJ,
flag and skin-tone joining, VS16 widening and Hangul jamo composition, plus
the codepoint-widths and variation-selector-always-wide options. Both rows
were mis-measured alike, so the width check passed and the delta put text
in the wrong column, e.g. a spinner next to a thumbs-up or a flag.

Rows holding any character whose width the two models may disagree on now
keep the whole-row write, and pane rows skip the cell delta entirely when
the session's width options differ from the defaults.

Signed-off-by: Jiun Bae <jiunbae.623@gmail.com>
@jiunbae
jiunbae merged commit 5af57c3 into main Oct 18, 2026
@jiunbae
jiunbae deleted the sync/upstream-pr-branches branch October 18, 2026 05:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant