Repository navigation
Conversation
jdwile
reviewed
Oct 14, 2026
| "tag": { | ||
| "type": "string", | ||
| "enum": ["lms"] | ||
| "enum": ["lms", "Boss", "Raid", "Clue", "Misc", "BPet", "SPet", "CA", "L99"] |
Contributor
There was a problem hiding this comment.
Why do these need to be shortened? Can't they just be "Boss Pet" / "Skilling Pet" / "Combat Achievement" / "Level 99"
Member
There was a problem hiding this comment.
boss-pet, skilling-pet, etc. pls
rmobis
requested changes
Oct 14, 2026
rmobis
left a comment
rmobis
left a comment
Member
There was a problem hiding this comment.
Still gotta check the master and extra tier, but other than the few comments I left, all looking good.
| } | ||
| }, | ||
| { | ||
| "id": "ecf1d31c-086c-4a29-9875-1f3cacabd11b", |
Member
There was a problem hiding this comment.
This task (same count) keeps the old id. Previous ones get new ids.
| "name": "Get 1 unique from Raids", | ||
| "shortName": "Raids", | ||
| "tip": "Can be received as a drop from any raid: Chambers of Xeric, Theatre of Blood or Tombs of Amascut.", | ||
| "tip": "Can be received as a drop from any raid: Chambers of Xeric, Theatre of Blood, Tombs of Amascut or The Fractured Archive.", |
Member
There was a problem hiding this comment.
Feel like explicitly naming FRED before it can actually complete the task will just get people asking if they can do their raids task there (which I believe we decided they couldn't?)
| "imageLink": "https://oldschool.runescape.wiki/images/thumb/Mystic_boots_(dusk)_detail.png/320px-Mystic_boots_(dusk)_detail.png", | ||
| "displayItemId": 23059 | ||
| "wikiLink": "https://oldschool.runescape.wiki/w/Brimstone_chest", | ||
| "imageLink": "https://oldschool.runescape.wiki/images/thumb/Brimstone_key_detail.png/1024px-Brimstone_key_detail.png", |
| "name": "Get a Gilded full helm", | ||
| "tip": "Obtained very rarely from hard, elite and master clues.", | ||
| "wikiLink": "https://oldschool.runescape.wiki/w/Gilded_full_helm", | ||
| "imageLink": "https://oldschool.runescape.wiki/images/thumb/Gilded_full_helm_detail.png/110px-Gilded_full_helm_detail.png", |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Master tier rework
Chompy Hat rework
Misc changes