Skip to content

[20.0][MIG] spreadsheet_dashboard_purchase_oca: Migration to 20.0 - #133

Merged
OCA-git-bot merged 11 commits into
OCA:20.0from
ledoent:20.0-mig-spreadsheet_dashboard_purchase_oca
Oct 23, 2026
Merged

OCA-git-bot merged 11 commits into
OCA:20.0from
ledoent:20.0-mig-spreadsheet_dashboard_purchase_oca

Conversation

@dnplkndll

@dnplkndll dnplkndll commented Sep 29, 2026 •

Copy link
Copy Markdown

Port of spreadsheet_dashboard_purchase_oca from 19.0 to 20.0. Follows the OCA migration guide.

Non-mechanical adaptations worth flagging

  • Dashboard sheet background (data/files/vendors_dashboard.json). 19.0 forced the dashboard grid white from spreadsheet_dashboard/.../dashboard_action.scss (.o_spreadsheet_dashboard_action { background-color: white; … .o-grid { background-color: white } }). 20.0 dropped both rules and instead sets --os-canvas-background-color: #{$o-navbar-background}, while o-spreadsheet gained a per-sheet backgroundColor whose renderer falls back to ctx.clearRect() when it is unset — so a sheet carrying no backgroundColor now paints transparent over the navbar colour. All 28 core 20.0 dashboard payloads were regenerated with "backgroundColor": "#F9FAFB"; this port sets the same value on the Dashboard sheet. The rest of the payload is unchanged from 19.0.

AI-assisted (Claude Code); every change reviewed, tested, and owned by the author.

Odoo and others added 10 commits September 28, 2026 11:29
Copied as is from Odoo 17.0 branch. Later commits will do the needed
changes.
Currently translated at 100.0% (27 of 27 strings)

Translation: spreadsheet-18.0/spreadsheet-18.0-spreadsheet_dashboard_purchase_oca
Translate-URL: https://translation.odoo-community.org/projects/spreadsheet-18-0/spreadsheet-18-0-spreadsheet_dashboard_purchase_oca/it/
Currently translated at 100.0% (27 of 27 strings)

Translation: spreadsheet-18.0/spreadsheet-18.0-spreadsheet_dashboard_purchase_oca
Translate-URL: https://translation.odoo-community.org/projects/spreadsheet-18-0/spreadsheet-18-0-spreadsheet_dashboard_purchase_oca/fr/
Currently translated at 100.0% (31 of 31 strings)

Translation: spreadsheet-19.0/spreadsheet-19.0-spreadsheet_dashboard_purchase_oca
Translate-URL: https://translation.odoo-community.org/projects/spreadsheet-19-0/spreadsheet-19-0-spreadsheet_dashboard_purchase_oca/it/
Signed-off-by: Don Kendall <dkendall@ledoweb.com>
Assisted-by: Claude Code
@pilarvargas-tecnativa

Copy link
Copy Markdown
Contributor

The dashboard styles need some adjustment for 20.0. At least the background appears purple and looks inconsistent with the standard dashboards. Could you review the dashboard styling and align it with the current design?
image

@Tecnativa TT64884

@dnplkndll
dnplkndll force-pushed the 20.0-mig-spreadsheet_dashboard_purchase_oca branch 2 times, most recently from 8d44ea1 to 166c1f9 Compare October 20, 2026 13:31
@dnplkndll

Copy link
Copy Markdown
Author

@pilarvargas-tecnativa updated.

I missed it because my production instance overrides that. so it showed up as my own brand amber.

@pilarvargas-tecnativa pilarvargas-tecnativa left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@pilarvargas-tecnativa

Copy link
Copy Markdown
Contributor

@carlos-lopez-tecnativa please review

@pedrobaeza

Copy link
Copy Markdown
Member

Have you checked in runbot how the enterprise dashboard looks on 20? For getting/mimicking ideas from it.

@pilarvargas-tecnativa

Copy link
Copy Markdown
Contributor
image

The KPI cards at the top now have white backgrounds, and each section, such as “Top Products”, has a white card wrapping both its title and content. In the migrated dashboard (left screenshot), the “Top Vendors” background only covers part of the section, while “Top Orders” and the other sections lack that white background. These are the styling changes that need to be applied in this migration.

@dnplkndll

Copy link
Copy Markdown
Author

I had looked as well and already done that. will push here now.

@dnplkndll
dnplkndll force-pushed the 20.0-mig-spreadsheet_dashboard_purchase_oca branch from 166c1f9 to 3455f70 Compare October 22, 2026 11:35
dnplkndll added a commit to ledoent/spreadsheet that referenced this pull request Oct 22, 2026
Assisted-by: Claude Opus 5
@pilarvargas-tecnativa

Copy link
Copy Markdown
Contributor

Something has thrown off the sizing of the top KPI cards

image

And the layout of the other tables is also different.

image

* data/dashboards.xml: payload loads with type="bytes", not type="base64".
* vendors_dashboard.json: Dashboard sheet backgroundColor #F9FAFB, as core.
* vendors_dashboard.json: adopt the 20.0 dashboard styling — white KPI cards
  and a card around each section's title and content, on the original layout.

Signed-off-by: Don Kendall <dkendall@ledoweb.com>
Assisted-by: Claude Opus 5
@dnplkndll
dnplkndll force-pushed the 20.0-mig-spreadsheet_dashboard_purchase_oca branch from 3455f70 to b93205a Compare October 23, 2026 01:24

@pilarvargas-tecnativa pilarvargas-tecnativa left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@pedrobaeza pedrobaeza left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on runboat

/ocabot merge patch

@OCA-git-bot

Copy link
Copy Markdown
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 20.0-ocabot-merge-pr-133-by-pedrobaeza-bump-patch, awaiting test results.

@OCA-git-bot
OCA-git-bot merged commit f03a117 into OCA:20.0 Oct 23, 2026
7 checks passed
@OCA-git-bot

Copy link
Copy Markdown
Contributor

Congratulations, your PR was merged at 6d1d7bb. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants