Repository navigation
fix!: warn on duplicated code at stop instead of blocking - #1
Merged
Merged
Conversation
All Stop hooks share one stop_hook_active flag. When drygate blocked a turn, the continued turn arrived with the flag set, and flocc's Stop hook read that as its own refusal already spent and let the agent end without reporting. The Stop hook now reports added clones through systemMessage and moves the snapshot forward on every checked stop, so each copy is reported once. Signed-off-by: NovusEdge <khimanialiasgar@gmail.com>
|
Caution Review failedThe pull request is closed.
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Stop hook now warns through
systemMessageand never returnsdecision: block.All Stop hooks share one
stop_hook_activeflag. After a drygate block, the continued turn arrives with the flag set, and flocc's Stop hook (src/flocc/cli.py:230in NovusEdge/flocc) reads that as its own refusal already spent. It then lets the agent end the turn withoutflocc done.node --test tests/drygate.test.js: 29 pass.