Skip to content

fix!: warn on duplicated code at stop instead of blocking - #1

Merged
NovusEdge merged 1 commit into
mainfrom
fix/warn-not-block
Oct 31, 2026
Merged

NovusEdge merged 1 commit into
mainfrom
fix/warn-not-block

Conversation

@NovusEdge

Copy link
Copy Markdown
Owner

The Stop hook now warns through systemMessage and never returns decision: block.

All Stop hooks share one stop_hook_active flag. After a drygate block, the continued turn arrives with the flag set, and flocc's Stop hook (src/flocc/cli.py:230 in NovusEdge/flocc) reads that as its own refusal already spent. It then lets the agent end the turn without flocc done.

  • The snapshot moves forward on every checked stop, so each copy is reported once.
  • The README notes the cost: the warning reaches the user, not the agent, so unattended sessions get no duplicate check at stop.
  • Version 0.2.0 in both manifests.

node --test tests/drygate.test.js: 29 pass.

All Stop hooks share one stop_hook_active flag. When drygate blocked a
turn, the continued turn arrived with the flag set, and flocc's Stop hook
read that as its own refusal already spent and let the agent end without
reporting. The Stop hook now reports added clones through systemMessage
and moves the snapshot forward on every checked stop, so each copy is
reported once.

Signed-off-by: NovusEdge <khimanialiasgar@gmail.com>
@coderabbitai

coderabbitai Bot commented Oct 31, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Caution

Review failed

The pull request is closed.

  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@NovusEdge
NovusEdge merged commit c906f9d into main Oct 31, 2026
6 checks passed
@NovusEdge
NovusEdge deleted the fix/warn-not-block branch October 31, 2026 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant