Repository navigation
CI: a push to main does not cancel a running deploy - #94
Merged
Merged
Conversation
cancel-in-progress applied to every ref, and deploy-server runs on a push to main, so a second push during a deploy cancelled it. A cancel between the deploy's systemctl stop and systemctl start left the public cache down with nothing to start it. Only a pull request's run is cancelled by a newer push to it, as in nova-nix's ci.yml.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cancel-in-progress: trueapplies to every ref, anddeploy-serverruns on a push to main. A second push during a deploy cancels it, and a cancel betweensystemctl stopandsystemctl startleaves the public cache down with nothing to start it.Only a pull request's run is cancelled by a newer push to it, as in nova-nix's
ci.yml:cancel-in-progress: ${{ github.event_name == 'pull_request' }}.Checked: actionlint 1.7.12 passes on the workflow. Not exercised: a deploy with a second push behind it. The expression is the one nova-nix's workflow already runs with.
Closes #88