Repository navigation
configure-lib: List lib/windows/lseek.c once - #2
Merged
Merged
Conversation
libmes_SOURCES takes lib/windows/lseek.c for mes_kernel=windows, as it takes lib/linux/lseek.c and lib/stub/lseek.c for linux and gnu, and the Windows block of libc_SOURCES named it a second time. libc, libc+tcc and libc+gnu, which all start from libmes_SOURCES, therefore defined lseek and _lseek twice. MesCC emits both, and hex2 resolves a label defined twice to the later one, so the libraries MesCC builds were unaffected; a compiler that rejects a redefinition, as TinyCC does, cannot build a library concatenated from the list. * build-aux/configure-lib.sh (libc_SOURCES): Do not list lib/windows/lseek.c for mes_kernel=windows a second time.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
libmes_SOURCEStakeslib/windows/lseek.cformes_kernel=windows(line 143), as it takeslib/linux/lseek.cfor linux, and the Windows block oflibc_SOURCESnamed it a second time (line 306). libc, libc+tcc and libc+gnu, which all start fromlibmes_SOURCES, therefore definedlseekand_lseektwice. MesCC emits both and hex2 resolves a twice-defined label to the later one, so the libraries MesCC builds were unaffected; a compiler that rejects a redefinition, as TinyCC does, cannot build a library concatenated from the list.This drops the second entry. The lists regenerated from the fixed tree name each file once: libc 112, libc+tcc 169, gnu 100 + 169.
The Windows CI builds mes-m2 from
kaem.windows.run, which does not readconfigure-lib.sh, so it shows only that nothing else changed.