Repository navigation
Conversation
Contributor
|
Thanks for the precise diagnosis! Merged via #23: the directory is now created for every agent install source (local binary, build, release), with a test. You are credited as co-author. Will ship in the next release. |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem. Node onboarding fails at the agent-install step (remote_install_failed, exit 1) on hosts where /usr/local/bin does not exist. The bootstrap script runs install -m 0755 /usr/local/bin/nodeflow-node-agent.new without creating the directory first. When it’s missing, install fails with ENOENT and set -eu aborts the whole script before the agent is activated — no systemd unit, no agent start, full rollback, nothing in journald (very hard to diagnose).
/usr/local/libexec is already created via install -d (for the updater); /usr/local/bin is not — an inconsistency.
Fix. Add install -d -m 0755 /usr/local/bin before the agent binary install, in both the panel SSH bootstrap and the manual installer.
How found. strace on the piped sh -s install process showed install exit 1 on openat("/usr/local/bin/nodeflow-node-agent.new", O_WRONLY|O_CREAT|O_EXCL) = -1 ENOENT. A mkdir -p /usr/local/bin made onboarding succeed immediately.