Skip to content

Campaigns: offer-first setup, offer combining rule, campaign clone - #66

Open
next-devin wants to merge 2 commits into
mainfrom
offer-first-setup
Open

next-devin wants to merge 2 commits into
mainfrom
offer-first-setup

Conversation

@next-devin

Copy link
Copy Markdown
Contributor

Campaigns App shipped a new setup flow on 2026-10-14 (campaigns-app epic #577). Selecting store products in an offer now creates the campaign's packages, the Packages tab is now Products, and only one automatic offer of each benefit type applies to an order. The API shapes are unchanged.

Changes

  • docs/index.mdx: Get started step 2 now says to create offers, which add the packages.
  • campaigns/index.mdx: packages come from offers in the dashboard; IDs are on the Products tab; new paragraph on how offers combine (which automatic offer wins, codes compound, level order) and the Offer Preview; count_equal added to the condition table; rounding wording corrected (no ending floors to the cent; rounding never raises a price).
  • campaigns/api/index.mdx: Packages paragraph.
  • campaigns/admin-api/index.mdx: 5-step provisioning flow (offers added); new Clone a Campaign section; note to list packages before creating more, since the dashboard may already have made them; available: false on offer create; offer code must be unique per campaign, ignoring case; Clone added to the endpoints table.
  • campaigns/admin-api/campaigns/meta.json: Campaigns Clone in the sidebar (its reference page is already generated from the spec).

Checked: npm run build passes.

Not included: refreshing public/api/admin/*.yaml. The 10-14 release changed the offer code help text ("unique within the campaign (case-insensitive)"); the next tools/update_api_docs.py run will pick it up. The spec also lists clone's success as 200; the endpoint returns 201.

Campaigns App now creates packages when an offer selects store
products, lists them on the Products tab, and applies only one
automatic offer of each benefit type. Also documents the campaign
clone endpoint, creating offers with available: false, and per-campaign
unique offer codes.
@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Oct 14, 2026 •

Copy link
Copy Markdown

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Preview URL Updated (UTC)
✅ Deployment successful!
View logs
developer-docs 2976075 Commit Preview URL

Branch Preview URL
Oct 14 2026, 09:03 AM

Comment thread content/docs/campaigns/index.mdx Outdated
Comment thread content/docs/campaigns/admin-api/index.mdx
@kilo-code-bot

kilo-code-bot Bot commented Oct 14, 2026 •

Copy link
Copy Markdown

Code Review Summary

Status: No Issues Found | Recommendation: Merge

Files Reviewed (2 files)
  • content/docs/campaigns/admin-api/index.mdx
  • content/docs/campaigns/index.mdx

Both previously reported SUGGESTIONs were addressed in this incremental revision and verified against current HEAD (2976075c):

  • content/docs/campaigns/index.mdx line 184 — the priority rule is now an explicit tie-break chain (larger minimum wins; among equal minimums, count_equal beats count, then larger discount, then oldest), resolving the previous ambiguity.
  • content/docs/campaigns/admin-api/index.mdx line 49 — the 5-step provisioning overview's step 3 now surfaces the dashboard-package caveat inline ("If the campaign was started in the dashboard, list its packages with campaignsPackagesList first: saving an offer there creates packages for the products it selects"), so it is no longer hidden in the later "Add Packages" subsection.

No new issues were introduced on the changed lines.

Previous Review Summary (commit 583ee96)

Current summary above is authoritative. Previous snapshots are kept for context only.

Previous review (commit 583ee96)

Status: 2 Issues Found | Recommendation: Address before merge

Overview

Severity Count
CRITICAL 0
WARNING 0
SUGGESTION 2
Issue Details (click to expand)

SUGGESTION

File Line Issue
content/docs/campaigns/index.mdx 184 count_equal priority rule wording is ambiguous — it's unclear whether count_equal is a tie-breaker among matching offers or a general override of count offers
content/docs/campaigns/admin-api/index.mdx 89 5-step provisioning overview doesn't surface the caveat that the dashboard may have already created packages, risking duplicates for developers following the overview
Files Reviewed (5 files)
  • content/docs/campaigns/admin-api/campaigns/meta.json - 0 issues
  • content/docs/campaigns/admin-api/index.mdx - 1 issue
  • content/docs/campaigns/api/index.mdx - 0 issues
  • content/docs/campaigns/index.mdx - 1 issue
  • content/docs/index.mdx - 0 issues

Fix these issues in Kilo Cloud


Reviewed by minimax-m3 · Input: 24.8K · Output: 2.3K · Cached: 170.2K

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant