Repository navigation
Campaigns: offer-first setup, offer combining rule, campaign clone - #66
Merged
Merged
Conversation
Campaigns App now creates packages when an offer selects store products, lists them on the Products tab, and applies only one automatic offer of each benefit type. Also documents the campaign clone endpoint, creating offers with available: false, and per-campaign unique offer codes.
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
developer-docs | 2976075 | Commit Preview URL Branch Preview URL |
Oct 14 2026, 09:03 AM |
![kilo-code-bot[bot]](https://avatars.githubusercontent.com/in/2193792?s=60&v=4){kind=small}
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Files Reviewed (2 files)
Both previously reported SUGGESTIONs were addressed in this incremental revision and verified against current HEAD (
No new issues were introduced on the changed lines. Previous Review Summary (commit 583ee96)Current summary above is authoritative. Previous snapshots are kept for context only. Previous review (commit 583ee96)Status: 2 Issues Found | Recommendation: Address before merge Overview
Issue Details (click to expand)SUGGESTION
Files Reviewed (5 files)
Reviewed by minimax-m3 · Input: 24.8K · Output: 2.3K · Cached: 170.2K |
…n the provisioning steps
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Campaigns App shipped a new setup flow on 2026-10-14 (campaigns-app epic #577). Selecting store products in an offer now creates the campaign's packages, the Packages tab is now Products, and only one automatic offer of each benefit type applies to an order. The API shapes are unchanged.
Changes
docs/index.mdx: Get started step 2 now says to create offers, which add the packages.campaigns/index.mdx: packages come from offers in the dashboard; IDs are on the Products tab; new paragraph on how offers combine (which automatic offer wins, codes compound, level order) and the Offer Preview;count_equaladded to the condition table; rounding wording corrected (no ending floors to the cent; rounding never raises a price).campaigns/api/index.mdx: Packages paragraph.campaigns/admin-api/index.mdx: 5-step provisioning flow (offers added); new Clone a Campaign section; note to list packages before creating more, since the dashboard may already have made them;available: falseon offer create; offercodemust be unique per campaign, ignoring case; Clone added to the endpoints table.campaigns/admin-api/campaigns/meta.json: Campaigns Clone in the sidebar (its reference page is already generated from the spec).Checked:
npm run buildpasses.Not included: refreshing
public/api/admin/*.yaml. The 10-14 release changed the offercodehelp text ("unique within the campaign (case-insensitive)"); the nexttools/update_api_docs.pyrun will pick it up. The spec also lists clone's success as200; the endpoint returns201.