Repository navigation
Monthly shares from donor gauges (#102) - #106
Merged
NewGraphEnvironment merged 20 commits intoOct 20, 2026
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01TaHJkAqd9xHDZQmhpQoVbW
…ny candidate code Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01TaHJkAqd9xHDZQmhpQoVbW
…th the daily shape (#102) wet_donor_mean() is wet_shape_predict()'s donor weighting, moved so the monthly shares use the same recipe; the shape's output is identical (tested against the old branch written out). The regression's predictions are identical too. R/wet_donor_mean.R joins the scoring hash and the shape hash. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01TaHJkAqd9xHDZQmhpQoVbW
… ship by #102's rule wb_validate.R applies the rule registered in a8ca570 after #16's, on its static set; fits.rds and cv_aet-<AET>.rds carry share_method and every method's held-out shares. The monthly vignette data and the publish description read the shipped method. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01TaHJkAqd9xHDZQmhpQoVbW
The LOO label, the report's AET line, NA-share counts, the publish description (byte-identical for the regression) and wb_shape_daily.R's method check; the header records how the code reads four details the rule leaves to its references. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01TaHJkAqd9xHDZQmhpQoVbW
…es use CGIAR monthly AET (#102) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01TaHJkAqd9xHDZQmhpQoVbW
…ette refuses a donor bundle until its prose is rewritten, one unchecked claim dropped (#102) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01TaHJkAqd9xHDZQmhpQoVbW
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01TaHJkAqd9xHDZQmhpQoVbW
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01TaHJkAqd9xHDZQmhpQoVbW
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01TaHJkAqd9xHDZQmhpQoVbW
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01TaHJkAqd9xHDZQmhpQoVbW
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01TaHJkAqd9xHDZQmhpQoVbW
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01TaHJkAqd9xHDZQmhpQoVbW
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01TaHJkAqd9xHDZQmhpQoVbW
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01TaHJkAqd9xHDZQmhpQoVbW
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01TaHJkAqd9xHDZQmhpQoVbW
…ca2dee (#102) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01TaHJkAqd9xHDZQmhpQoVbW
… build 8ca2dee, publish record (#102) The article's balance passages and their checks are rewritten: at the calibration gauges the balance now carries the gauge's own monthly pattern at its annual flow; at 08EE003 it is several times the gauge in the late-summer windows; its median monthly error is within 10 % in every month, the Liard's winter included; it is the stronger source under 1,000 km2. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01TaHJkAqd9xHDZQmhpQoVbW
… rerun, three claims held to their reports, a window check that tests its sentence (#102) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01TaHJkAqd9xHDZQmhpQoVbW
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01TaHJkAqd9xHDZQmhpQoVbW
NewGraphEnvironment
deleted the
102-monthly-shares-from-donor-gauges-day-of
branch
October 20, 2026 03:51
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
scripts/wb_validate.R's header (a8ca570) before any candidate code existed.wet_share_fit(method = "regression" | "donor" | "blend").wet_donor_mean(), shared with Sub-monthly flow per segment: a daily climatology for both sources, with weeks and windows derived from it #70's daily shape; the shape's output is identical, and tested.share_method.scripts/wb_share_donor.Rbreaks the result down.Related Issues
Test plan
devtools::test(): 1227 passed, 0 failed (after the R changes; nothing underR/changed since)/code-checkrounds (records in the archive)Notes
data/logs/102/from m4'swet-102worktree into the main checkout, then remove the worktree.research/water_balance_method.md§0, "Monthly shares from donor gauges (Monthly shares from donor gauges' day-of-year records: #70 measured 0.939 against the shipped 0.874 #102)"; archiveplanning/archive/2026-10-issue-102-donor-monthly-shares/.🤖 Generated with Claude Code
https://claude.ai/code/session_01TaHJkAqd9xHDZQmhpQoVbW