Skip to content

README: what flooded does today, to soul's readme.md (#81) - #86

Merged
NewGraphEnvironment merged 19 commits into
mainfrom
81-readme-add-dem-fetch-flood-factor-scenarios
Oct 16, 2026
Merged

NewGraphEnvironment merged 19 commits into
mainfrom
81-readme-add-dem-fetch-flood-factor-scenarios

Conversation

@NewGraphEnvironment

@NewGraphEnvironment NewGraphEnvironment commented Oct 15, 2026 •

Copy link
Copy Markdown
Owner

Summary

  • README rewritten to soul conventions/readme.md: what flooded maps and what each resolution shows, how the Valley Confinement Algorithm works and where it comes from, what a run needs and where those inputs come from, a Parsnip figure built by data-raw/readme_figure.R, a bundled-reach example with its real output, and Learn more, Ecosystem, Data and methods, Citation and License sections.
  • After the review rounds the README was revised with the operator: plainer and less hedged, a How it works and a What it needs section, inputs traced to their sources (MRDEM-30, stac-elevation-bc, stac-pointcloud-bc, fwapg, ClimateBC), floodplains and stac-floodplains-bc in Learn more, and an ecosystem table linked to each package's site (diggs and breaks out; wet and stac_floodplains_bc in).
  • DESCRIPTION's Title and Description follow the tagline and opening. New Graph Environment Ltd. is cph and fnd, now that LICENSE on main names it; the citation workflow passes authors_roles = c("aut", "cre", "fnd"), so CITATION.cff lists Allan Irvine and NGE Ltd.
  • inst/NOTICE.md gives the licence of every redistributed dataset. LICENSE.note now ships in the tarball.
  • The pkgdown reference index is grouped by purpose.
  • The stale threads timing is re-measured on the Parsnip grid: threads 1 and 8 overlapped under load, so no threads effect is claimed.

Related Issues

Test plan

  • devtools::check(--no-manual): 0 errors, 0 warnings. The 2 NOTEs predate this branch (CITATION.cff and pkgdown/ at top level).

  • Tests, examples and vignette rebuild pass. lintr flags nothing in changed lines.

  • pkgdown::check_pkgdown() and build_site(): the figure is served and the six reference sections render.

  • The README example re-runs under load_all() and matches its pasted output. Every README link resolves, except the inst/NOTICE.md link, which resolves after merge.

  • /code-check branch, three rounds:

    • Round 1: 62 claims, 8 findings.
    • Round 2: 64 claims, 6 findings, 4 of them inside round 1's fixes.
    • Round 3: a 92-claim enumeration, 2 low findings.

    All fixed.

Notes

  • At merge: set the GitHub About text to the new tagline: gh repo edit NewGraphEnvironment/flooded --description "Map floodplains from an elevation model and a stream network". It was held back because it goes public immediately.
  • LICENSE on main now names New Graph Environment Ltd., so it is cph as well as fnd (merged in before release).
  • README length: 406 to 600 prose words, against a 450-500 forecast. The required sections add about 300 words. The breakdown is in the archive README.
  • The planning record and measurements are in planning/archive/2026-10-issue-81-readme-refresh/.

🤖 Generated with Claude Code

https://claude.ai/code/session_0186ZefY3qMPiW8pwnwwMuxW

NewGraphEnvironment and others added 19 commits October 15, 2026 15:28
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_0186ZefY3qMPiW8pwnwwMuxW
…CE in inst/ (#81)

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_0186ZefY3qMPiW8pwnwwMuxW
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_0186ZefY3qMPiW8pwnwwMuxW
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_0186ZefY3qMPiW8pwnwwMuxW
Says where the model comes from (USFS Valley Confinement Algorithm, ported
from BlueGeo and bcfishpass) and the three criteria it applies, instead of
what it is not. DESCRIPTION's Description follows the new opening. Body
prose 602 -> 536 words with the new section included.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_0186ZefY3qMPiW8pwnwwMuxW
… come from (#81)

How it works now opens with what the Valley Confinement Algorithm delineates
(unconfined valley bottoms). A new What it needs section names the default
elevation model (MRDEM-30, fetched by area of interest), that any projected
DEM in metres works (e.g. stac-elevation-bc lidar), and that mean annual
precipitation comes from ClimateBC through bcfishpass in BC.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_0186ZefY3qMPiW8pwnwwMuxW
…sed (#81)

The opening says what a 30 m run maps before the lidar use. The figure
caption links link's Parsnip article for how bull trout access is
modelled. What it needs links stac-elevation-bc and stac-pointcloud-bc,
bcfishpass and link for streams, and fwapg/ClimateBC for precipitation.
The ecosystem table links each package's site, drops diggs and breaks,
and adds wet and stac_floodplains_bc.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_0186ZefY3qMPiW8pwnwwMuxW
…t each holds (#81)

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_0186ZefY3qMPiW8pwnwwMuxW
… in Data and methods (#81)

What it needs names our own packages for streams and drops the bcfishpass
pass-through for precipitation. Data and methods credits fwapg for the
Freshwater Atlas, upstream area and ClimateBC precipitation, keeps
bcfishpass for adapted code and the bundled attributes, and links #87 for
moving the bundled data to link-built tables.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_0186ZefY3qMPiW8pwnwwMuxW
…not required (#81)

The raw Freshwater Atlas in the BC Data Warehouse carries no upstream area
(FWA_STREAM_NETWORKS_SP columns checked), so the input line names fwapg,
which adds it and ClimateBC precipitation to every segment.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_0186ZefY3qMPiW8pwnwwMuxW
…ch-flood-factor-scenarios

* origin/main:
  Hex sticker: keep the small logo's name clear of the icon
  pkgdown: cap the job at 90 minutes
  LICENSE: New Graph Environment Ltd. holds the copyright
@NewGraphEnvironment
NewGraphEnvironment merged commit 8def510 into main Oct 16, 2026
1 check passed
@NewGraphEnvironment
NewGraphEnvironment deleted the 81-readme-add-dem-fetch-flood-factor-scenarios branch October 16, 2026 04:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

README: add DEM fetch, flood-factor scenarios, per-watercourse attribution and the Parsnip vignette

1 participant