Skip to content

NethVoice: TOPOS and SRTP options missing from trunks #8311

Closed

Description

@Stell0

Steps to reproduce

  1. Open the NethVoice advanced PBX interface.
  2. Open Connectivity → Trunks and add or edit a PJSIP trunk.
  3. Open PJSIP Settings → Advanced and find the Outbound Proxy field.

Expected behavior

The page provides the Disable TOPOS proxy header and Disable SRTP proxy header options, as in NethVoice 1.7.14. They allow configuring the topos=0 and isTrunk=1 headers for the trunk.

Actual behavior

The options are missing even though their rendering, storage and dialplan code remain present.

The current NethCTI GUI hook inserts the fields through an output-buffer callback. For normal and popover responses, FreePBX config.php first copies the unmodified HTML with ob_get_contents() and then discards the buffer with ob_end_clean(). The callback's replacement HTML is discarded, so neither control reaches the response. The previous regression test flushed the buffer instead of reproducing this capture-and-clean sequence and therefore passed incorrectly. A local reproduction of the actual sequence produces zero TOPOS and zero SRTP controls.

Components

NethVoice main, with FreePBX Core 17.0.18.54 and framework 17.0.33.2. Compared with NethVoice 1.7.14.

Suggested fix

Restore trunk page interception so the fields are inserted before the framework captures the response. Correct Core's $module_hook == moduleHook::create() typo to an assignment so the page can safely render in the interceptor's scope, and cover normal, popover and quiet responses in the regression.

Activity

  1. added this to the NethVoice 1.8 milestone on Nov 11, 2026
  2. added
    nethvoiceBug or features releted to the NethVoice project
    on Nov 11, 2026
  3. added theissue type on Nov 11, 2026
  4. moved this from Todo to In Progress in NethVoiceon Nov 11, 2026
  5. added
    testingPackages are available from testing repositories
    on Nov 11, 2026
  6. moved this from In Progress to Testing in NethVoiceon Nov 11, 2026
  7. assigned and unassigned on Nov 11, 2026
  8. edospadoni commented on Nov 11, 2026

    @edospadoni
    Member
  9. mgarra commented on Nov 12, 2026

    @mgarra

    Tested and verified.

  10. added
    verifiedAll test cases were verified successfully
    and removed
    testingPackages are available from testing repositories
    on Nov 12, 2026
  11. moved this from Testing to Verified in NethVoiceon Nov 12, 2026
  12. moved this from Verified to In Progress in NethVoiceon Nov 12, 2026
  13. moved this from In Progress to Verified in NethVoiceon Nov 12, 2026
  14. Stell0 commented on Nov 12, 2026

    @Stell0
    Author

    Release nethesis/ns8-nethvoice 1.8.2

  15. removed
    verifiedAll test cases were verified successfully
    on Nov 12, 2026
  16. moved this from Verified to Done in NethVoiceon Nov 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    nethvoiceBug or features releted to the NethVoice project

    Type

    Projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions