Skip to content

chore(starters): update solid-js to 1.9.17 - #395

Merged
coryrylan merged 1 commit into
mainfrom
topic/dependencies/starters/solid-js
Oct 9, 2026
Merged

coryrylan merged 1 commit into
mainfrom
topic/dependencies/starters/solid-js

Conversation

@cursor

@cursor cursor Bot commented Oct 9, 2026

Copy link
Copy Markdown

Update the Solid starter runtime dependency solid-js from 1.9.16 to 1.9.17.

solid-js is a runtime dependency, pinned exactly in projects/starters/solidjs/package.json dependencies. The starter is private and unpublished, so this is a chore(starters) change. vite-plugin-solid (solid-js ^1.7.2) and solid-devtools (solid-js ^1.9.0) already accept 1.9.17, so they stay on their current versions.

Release review: 1.9.17 was published on 2026-10-07 and is outside the 1140-minute release-age window. The patch updates bundled DOM Expressions from 0.40.11 to 0.40.12. Server rendering drops spread keys the HTML parser would treat as more than one name, throws for an invalid dynamic tag name (matching client document.createElement), and escapes class and style names. Output for valid names is unchanged. License stays MIT. Dependencies stay seroval and seroval-plugins ~1.6.8. No engine, peer, install, or migration change.

Generated changes are limited to pnpm-lock.yaml: the Solid starter pin and integrity, plus peer snapshot keys that reference solid-js. No other direct dependency moved. node ./projects/internals/ci/notice/index.js left every NOTICE.md unchanged. pnpm run notice is not a root script.

Validation:

  • mise exec -- pnpm run ci in projects/starters/solidjs: passed (24 scripts, 30.2s)
  • mise exec -- node .agents/skills/agent-dependencies/scripts/verify-update.js --type=chore --scope=starters: verified
  • CI=1 mise exec -- pnpm install --frozen-lockfile: passed
  • mise exec -- pnpm run ci from the repository root: passed (152 scripts, 24 skipped, 127.2s)
  • git diff --check: passed

The Angular 22.2 family was not included. Framework packages are eligible only through 22.2.1, while aligning @angular/cli and @angular/build crosses the 22.2.0 toolchain change that previously rewrote peer snapshots outside the starter.

Open in Web View Automation 

Signed-off-by: Cursor Agent <cursoragent@cursor.com>

Co-authored-by: Cory Rylan  <coryrylan@users.noreply.github.com>
@coderabbitai

coderabbitai Bot commented Oct 9, 2026 •

Copy link
Copy Markdown

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration
  • Configuration used: Repository: NVIDIA/elements/.coderabbit.yaml
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: b5e97429-b4a7-4653-8d78-64040bd248bf

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot added scope(ci) dependencies Pull requests that update a dependency file scope(starters) labels Oct 9, 2026
@cursor
cursor Bot marked this pull request as ready for review October 9, 2026 06:13
@github-code-quality

Copy link
Copy Markdown

Code Coverage Overview

Languages: TypeScript

TypeScript / code-coverage/vitest

The overall line coverage in commit 1c46088 in the topic/dependencies/s... branch remains at 99%, unchanged from commit 2a84274 in the main branch.

@coryrylan
coryrylan merged commit a841652 into main Oct 9, 2026
18 checks passed
@coryrylan
coryrylan deleted the topic/dependencies/starters/solid-js branch October 9, 2026 14:42
@coryrylan

Copy link
Copy Markdown
Collaborator

🎉 This issue has been resolved in version 2.0.8 🎉

Changelog

@coryrylan

Copy link
Copy Markdown
Collaborator

🎉 This issue has been resolved in version 2.15.0 🎉

Changelog

@coryrylan

Copy link
Copy Markdown
Collaborator

🎉 This issue has been resolved in version 2.7.2 🎉

Changelog

@coryrylan

Copy link
Copy Markdown
Collaborator

🎉 This issue has been resolved in version 1.1.0 🎉

Changelog

@coryrylan

Copy link
Copy Markdown
Collaborator

🎉 This issue has been resolved in version 2.1.0 🎉

Changelog

@coryrylan

Copy link
Copy Markdown
Collaborator

🎉 This issue has been resolved in version 1.0.0 🎉

Changelog

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file released scope(ci) scope(starters)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants