Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2617.
Depends on #2627; this draft should merge after that prerequisite.
Marks new binary-quantized segments with an NVIDIA-owned layout attribute, writes their flat vectors with Lucene102 binary storage, and keeps released unmarked segments readable through the legacy Lucene99 path. Marker/file mismatches fail as corruption rather than guessing, and mixed legacy/current merges rewrite to the marked layout.
Builds accelerated graphs from the original float vectors before the binary delegate flush, including the three-layer path, while retaining CPU fallback. The existing padded CAGRA serialization behavior from #2483 is unchanged.
Adds a checksum-pinned index fixture produced by the released 26.08 artifact plus GPU/CPU, compound/non-compound, mixed-merge, corruption, aligned/unaligned, and three-layer coverage. Search checks include rank-one identity, unique hits, and tie-aware brute-force recall floors.
Testing
mvn spotless:check verify(362 passed, 30 skipped)k=10(4/4 passed)The full GPU suite still emits existing cuVS graph-clamping, dataset-dimension, GDS-fallback, and JVM native-access/incubator warnings. The new three-layer compatibility case does not emit graph-parameter clamping warnings.