Skip to content

fix(drivers): normalize label namespace - #3609

Merged
drew merged 1 commit into
mainfrom
normalize-driver-label-prefix/elezar
Sep 23, 2026
Merged

drew merged 1 commit into
mainfrom
normalize-driver-label-prefix/elezar

Conversation

@elezar

@elezar elezar commented Sep 23, 2026

Copy link
Copy Markdown
Member

Summary

Normalize driver-owned label keys on the repository's canonical openshell.ai/ namespace. This removes the remaining openshell.io/ labels from the Podman and VM drivers and keeps their selectors, fixtures, E2E helpers, and documentation aligned.

Related Issue

No issue required: this is a localized consistency fix for existing driver label keys.

Changes

  • Changed Podman isolation-role labels and workload filters to openshell.ai/isolation-role
  • Changed the VM extension label prefix to openshell.ai/extension.
  • Updated Podman unit fixtures, E2E selectors, cleanup logic, and networking documentation
  • Audited the repository and confirmed no openshell.io/ label keys remain

Testing

  • mise run pre-commit passes
  • Unit tests added/updated
  • E2E tests added/updated (selectors updated; runtime E2E not required for the string-only change)
  • cargo test -p openshell-driver-podman
  • cargo test -p openshell-driver-vm lifecycle::tests

The full VM unit suite was also attempted. Its label-related lifecycle tests passed; seven unrelated tests could not complete because local e2fsprogs tools are unavailable or existing tracing fixtures timed out.

Checklist

  • Follows Conventional Commits
  • Commits are signed off (DCO)

Signed-off-by: Evan Lezar <elezar@nvidia.com>
@elezar elezar added this to the OpenShell 0.1.0 milestone Sep 23, 2026
@drew
drew added this pull request to the merge queue Sep 23, 2026
Merged via the queue into main with commit 6cb1140 Sep 23, 2026
72 checks passed
@drew
drew deleted the normalize-driver-label-prefix/elezar branch September 23, 2026 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants