Skip to content

fix(core): enforce owner-only Windows ACLs on sensitive files and dirs #3495

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
pkhodade-NV wants to merge 4 commits into
base: windows
Choose a base branch
from
Open

fix(core): enforce owner-only Windows ACLs on sensitive files and dirs #3495

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
868498e
fix(core): enforce owner-only Windows ACLs on sensitive files and dirs
pkhodade-NV Sep 17, 2026
a7060e3
fix(core): treat a NULL DACL as too open in is_file_permissions_too_open
pkhodade-NV Sep 17, 2026
25042e2
fix(core): close three false-negative gaps in the Windows ACL audit
pkhodade-NV Sep 22, 2026
7f699ae
Merge remote-tracking branch 'origin/windows' into fix/windows-acl-ow…
pkhodade-NV Sep 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ miette = { version = "7", features = ["fancy"] }
thiserror = "2"

# Windows platform APIs (ETW/TDH audit consumer in openshell-driver-mxc; Windows-only)
windows = { version = "0.62", features = ["Wdk_System_Threading", "Win32_Foundation", "Win32_NetworkManagement_IpHelper", "Win32_Networking_WinSock", "Win32_System_Diagnostics_Etw", "Win32_System_Time"] }
windows = { version = "0.62", features = ["Wdk_System_Threading", "Win32_Foundation", "Win32_NetworkManagement_IpHelper", "Win32_Networking_WinSock", "Win32_Security", "Win32_Security_Authorization", "Win32_Storage_FileSystem", "Win32_System_Diagnostics_Etw", "Win32_System_Memory", "Win32_System_SystemServices", "Win32_System_Threading", "Win32_System_Time"] }
anyhow = "1"

# Logging/Tracing
Expand Down
12 changes: 7 additions & 5 deletions architecture/gateway.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -446,11 +446,13 @@ For in-memory SQLite, the adapter retains a dedicated keepalive connection for
the store lifetime. Operational connection replacement therefore preserves the
shared in-memory schema and objects instead of creating an empty database.

The SQLite adapter tightens the on-disk database file to mode `0o600` on every
connect so that provider API keys, SSH session tokens, and sandbox metadata are
not readable by other local users on shared hosts. The same restriction is
reapplied to the `<db>-wal` and `<db>-shm` sidecars (created by SQLite's
default WAL journal mode), which mirror the same sensitive contents.
The SQLite adapter tightens the on-disk database file to owner-only access on
every connect so that provider API keys, SSH session tokens, and sandbox
metadata are not readable by other local users on shared hosts: mode `0o600`
on Unix, or a protected, owner-only DACL (with inherited ACEs stripped and
ownership taken) on Windows. The same restriction is reapplied to the
`<db>-wal` and `<db>-shm` sidecars (created by SQLite's default WAL journal
mode), which mirror the same sensitive contents.

Persisted state includes sandboxes, providers, provider profiles, provider
credential refresh state, SSH sessions, policy revisions, settings, deployment
Expand Down
3 changes: 3 additions & 0 deletions crates/openshell-core/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,9 @@ tempfile = { version = "3", optional = true }
nix = { workspace = true }
rustix = { workspace = true }

[target.'cfg(windows)'.dependencies]
windows = { workspace = true }

[features]
default = ["telemetry"]
## Compile in anonymous telemetry emission support. On by default; disable with
Expand Down
Loading
Loading