Repository navigation
Conversation
…turns Goal continuations are submitted as untracked prompts with a system_trigger/goal_continuation origin, so they never reached the prompt-submit gate and the externalHooks origin guard skipped them: UserPromptSubmit never fired for the whole duration of a goal session. - loop: run the prompt-submit gate for untracked prompts flagged with the new UserMeta.gated bit (opt-in, other system prompts unchanged) - goal: submit continuations with gated: true and settle a continuation that a UserPromptSubmit hook blocks by marking the goal blocked instead of silently stalling it - external hooks: fire UserPromptSubmit for goal_continuation origins and expose origin_kind/origin_name in the hook payload so consumers can distinguish continuations from user prompts Fixes MoonshotAI#3692
🦋 Changeset detectedLatest commit: a19913d The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Goal continuations are submitted as untracked prompts with a
system_trigger/goal_continuationorigin, so they never reached the prompt-submit gate and the externalHooks origin guard skipped them:UserPromptSubmitnever fired for the whole duration of a goal session (#3692).Two layers actually blocked the hook; both are addressed:
UserMeta.gatedbit — all other system prompts are unchanged.gated: true. A continuation that aUserPromptSubmithook blocks no longer stalls the goal silently (gate rejections never produce aTurnEnded); the goal is marked blocked with reasonBlocked by UserPromptSubmit hookand stays resumable.UserPromptSubmitforgoal_continuationorigins, and the payload now includesorigin_kind/origin_nameso consumers can distinguish continuations from user prompts. Docs (en/zh) updated accordingly.Covered by two end-to-end tests driving a real hook runner: continuation turns trigger the hook with
origin_name: goal_continuation, and a blocking hook (exit 2) marks the goal blocked without any model call.Fixes #3692