chore: Remove dead code and deduplicate internals - #272
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests.
🚀 New features to boost your workflow:
|
 |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
stephantul
approved these changes
Sep 24, 2026
stephantul
left a comment
stephantul
left a comment
Contributor
There was a problem hiding this comment.
One question about a conspicuous change but otherwise fine.
| """Distinguish between existence and permission issues.""" | ||
| try: | ||
| path.stat() | ||
| except FileNotFoundError: |
Member
Author
There was a problem hiding this comment.
yep just falls through to except OSError: return False later like before, effectively it was not doing anything
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes a bunch of dead code that was left over from older refactors or features we changed. There's also some deduplication, and
weighting.pyis now just folded intoboosting.pybecause it was only a couple of lines and only used there. Scores and speed on the benchmark are the exact same and all tests still pass.