fix: divide by length 1 instead of 1e-16 - #380
Merged
Merged
Conversation
Mean pooling divided by the number of tokens plus 1e-16. For a text without any tokens, the backward pass divided the gradient by 1e-16 after normalize had already scaled it up, which overflowed to inf and turned into NaN in the token weight gradient. Clamp the length to at least 1 instead: non-empty texts are unaffected, and empty texts get a zero embedding and a zero gradient.
stephantul
marked this pull request as ready for review
September 27, 2026 17:46
Codecov Report✅ All modified and coverable lines are covered by tests.
🚀 New features to boost your workflow:
|
|
Pringled
approved these changes
Sep 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mean pooling divided by the number of tokens plus 1e-16. For a text without any tokens, the backward pass divided the gradient by 1e-16 after normalization. This overflows to inf and turned into NaN in the token weight gradient. Clamp the length to at least 1 instead: non-empty texts are unaffected, and empty texts get a zero embedding and a zero gradient.