Repository navigation
fix: avoid reporting unsaved empty image responses - #301
Open
Ricardo-M-L wants to merge 1 commit into
Open
Ricardo-M-L wants to merge 1 commit into
Ricardo-M-L wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ImageSDK.save(response, { out })currently appends the destination to its returned list even when the selected image array is missing, empty, or contains an empty string. This reports a file that was never written and creates unnecessary directories. Whitespace-only base64 can also truncate an existing file to zero bytes.Return no saved paths before touching the filesystem when there is no nonblank single-image payload. Keep the existing multi-image error and valid URL/base64 save behavior.
Validation
bun run typecheck,bun run lint,bun run build, andgit diff --checkpass. Lint retains an existing warning intest/sdk/speech.test.ts.Agent-assisted contribution; tests and filesystem assertions use synthetic data and no paid API calls.
Need help on this PR? Tag
@codesmith-botwith what you need.