Repository navigation
Fix the Sandbox Provider setup review findings - #848
Merged
Merged
Conversation
Hide Advanced settings when it has nothing to show, keep the saved E2B template editable as text, show the Provider default on the review, derive the client's setup type and the E2B discovery fields from their declarations, delete the duplicate resource validator, and bring the docs up to date.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the blind-review findings on the Sandbox Provider setup work: the E2B Advanced page and template field defects, stale Web and protocol docs, and small leftovers (discovery field derivation, duplicate ValidateResources, derived client setup type, node installer HOSTS error, machine-api error-body sentence).
Need help on this PR? Tag
@codesmith-botwith what you need.