Repository navigation
Report official Turn error codes on the stream - #847
Merged
Merged
Conversation
Journaled Turn snapshots dropped the whole outcome, so every agent.session.turn.failed event reported internal_error while reads reported the classified code. Snapshots now keep Core's error code and the normalized model category, and nothing native. runtime_unavailable also covers Core failing to dispatch a Turn, so it reports internal_error; only a Runtime that disconnected or failed its preparation is sandbox_error. Docs that still described the generic Turn error and the old message rule are corrected.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
agent.session.turn.failedevents always reportedinternal_errorwhile Turn reads reported the classified official code. Snapshots now keep only Core'serror_codeand the normalized model category; native codes, text, HTTP status and the Runtime result stay out of the journal.runtime_unavailablealso covers Core failing to dispatch a Turn (execution_unavailable), so it now reportsinternal_error. Only a Runtime that disconnected or failed its preparation reportssandbox_error.Checks
go testsessions and api;go veton both.TestNativeClassificationPostgresRoundTripAndPublicPrivacy(now also asserts the streamed failed Turn carries the same public code).node --test website/tests/translations.test.mjs: hash tests pass; the inline-literals test needs vitepress, which is not installed locally.Need help on this PR? Tag
@codesmith-botwith what you need.