Repository navigation
chore: make just release open a pull request - #4
Merged
Merged
Conversation
main is protected and refuses direct pushes, so the old recipe always
failed at 'git push origin main' after it had already committed and
tagged locally.
The flow is now two steps:
just release <level> bumps the version on chore/release-<version>
and opens the pull request. Tags nothing.
just release-tag after the merge, tags main and pushes the tag,
which is what .github/workflows/publish.yml
listens for.
The tag is deliberately made after the merge. A tag made before it
would point at a commit that a squash or rebase merge discards, and a
published version cannot be taken back.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
mainis protected and refuses direct pushes, so the oldreleaserecipe always failed atgit push origin main— after it had already committed and tagged locally.The flow is now two steps:
just release <level>chore/release-<version>and opens the pull request. Tags nothing.just release-tagmainand pushes the tag — which is what.github/workflows/publish.ymllistens for.The tag is deliberately made after the merge. A tag made before it would point at a commit that a squash or rebase merge discards, and a published version cannot be taken back.