Repository navigation
feat!: mint file links at click time, and voice fixes for late interruptions - #39
Merged
Merged
Conversation
file.publish returns a sandbox:/ name instead of a signed URL. Listing a conversation's files and the stream's file frame carry facts only. IConversations.LinkFileAsync mints a five-minute link for one kept file when the person asks for it. BlobOwner.IsSafe is the one owner id rule, shared by the S3 store and the link lookup. Breaking: FileLink, Conversations.LinkFilesAsync, and the file frame's url field are gone. StoredConversation.Files is now a list of BlobRef.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change
file.publishreturns a stablesandbox:/name, not a signed URL.IConversations.LinkFileAsyncmints a five-minute link for one kept file when the person asks for it.BlobOwner.IsSafeis the one owner id rule. The S3 store and the link lookup share it.TextPlayback.Fullnow means every fragment reached the output, even when an interruption came after the last one.SpeechScheduler.CurrentSpeechno longer returns a speech that is already done.Public API
This breaks the API that v0.14.0 shipped:
FileLinkis removed.Conversations.LinkFilesAsyncis removed. UseLinkFileAsyncfor one file.urlfield is removed.StoredConversation.Filesis now a list ofBlobRef.Tests
ConversationsTests,FilePublishToolDefinitionTests,FileWireTests, andTurnStreamFilesTestscover the click-time link.ReplyHearingTests,TextForwardingTests, andTelnyxRelayLineSpokenTestscover the late interruption and the last words before a hang-up.