Repository navigation
Conversation
ggevay
marked this pull request as ready for review
October 8, 2026 14:17
ggevay
force-pushed
the
gabor/peek-seq-09-rename
branch
from
October 8, 2026 14:30
e3ae28c to
7c8ed04
Compare
ggevay
force-pushed
the
gabor/peek-seq-09-rename
branch
2 times, most recently
from
October 12, 2026 12:23
603801c to
28afc74
Compare
aljoscha
approved these changes
Oct 12, 2026
aljoscha
left a comment
Contributor
There was a problem hiding this comment.
Looks good, also okay with the renames to "my" code. Could you also do the follow-up then, please of updating my dashboard once this is in?
On the name peek_sequencing. Maybe we can find sth better. Sequencing used to be the specific thing that the coordinator does for plans. Ahh, on second though might be okay, we still "sequence" it, but just in the frontend. Leave as you want, sorry for the ramble... 😅
ggevay
force-pushed
the
gabor/peek-seq-09-rename
branch
from
October 12, 2026 20:13
28afc74 to
e4a13bc
Compare
ggevay
force-pushed
the
gabor/peek-seq-09-rename
branch
from
October 12, 2026 20:31
e4a13bc to
07f8cd3
Compare
ggevay
force-pushed
the
gabor/peek-seq-09-rename
branch
from
November 10, 2026 15:53
07f8cd3 to
80ef94a
Compare
ggevay
force-pushed
the
gabor/peek-seq-09-rename
branch
from
November 10, 2026 16:51
80ef94a to
3f566f4
Compare
Contributor
Author
|
Thanks! I'll update the panel on your dashboard once the stack is in. Keeping |
With the coordinator's peek sequencing gone, the session task's is the only one, so the `frontend_` prefix no longer tells two implementations apart. Pure rename, apart from the `mod` line and two comments that name the file. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The prefix distinguished the session task's peek sequencing from the coordinator's, which is gone: - `try_frontend_peek(_inner)` becomes `try_peek(_inner)`. The debug-level span and the debug logs follow, and `test_expected_spans` looks for `try_peek_inner`. - `frontend_determine_timestamp` becomes `determine_timestamp`. - `Command::RegisterFrontendPeek`/`UnregisterFrontendPeek` and their handlers become `RegisterPeek`/`UnregisterPeek`. The coordinator registers its own slow-path peeks without a command. - The MCP test case for SELECT becomes `select_not_vulnerable`. The metric label values that carry the old names change in the next commit. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Follow the renames of the previous commit in two metric label values:
- `mz_slow_message_handling{message_kind}`: `register-frontend-peek` and
`unregister-frontend-peek` become `register-peek` and `unregister-peek`.
- `mz_catalog_snapshot_seconds{context}` and
`mz_catalog_snapshot_cache{context}`: `try_frontend_peek` becomes
`try_peek`.
Dashboards that pick these values by name need the new ones from this
release on.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The coordinator's read-then-write path is gone, so the prefix no longer tells two implementations apart: - `try_frontend_read_then_write(_with_cancel)` becomes `try_read_then_write(_with_cancel)`, and `frontend_read_then_write_applies` becomes `read_then_write_applies`. The `context` label value of `mz_catalog_snapshot_seconds` and `mz_catalog_snapshot_cache` follows: `try_frontend_read_then_write` becomes `try_read_then_write`. - `PeekClient::frontend_read_then_write` becomes `session_read_then_write`, next to `background_read_then_write`. - `FrontendWriteAttemptState` and `FrontendWriteCancellation` become `WriteAttemptState` and `WriteCancellation`. - Tests: `test_occ_write_visible_to_linearizable_read`, five `test_statement_logging_*` tests, and the pgtest `occ-pipelined-dml.pt` (`test_pgtest_mz_occ_pipelined_dml`). The module keeps its name, `frontend_read_then_write`, next to its coordinator-side counterpart `coord::read_then_write`. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
ggevay
force-pushed
the
gabor/peek-seq-09-rename
branch
from
November 11, 2026 14:48
3f566f4 to
216f981
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With the coordinator's peek sequencing and read-then-write paths gone, the
frontend_prefix no longer tells two implementations apart in these names. Renames only, no behavior change.Best reviewed commit by commit:
frontend_peek.rsbecomespeek_sequencing.rs. Pure rename (git show -M).try_frontend_peek(_inner)becomestry_peek(_inner),frontend_determine_timestampbecomesdetermine_timestamp,Command::RegisterFrontendPeek/UnregisterFrontendPeekand their handlers becomeRegisterPeek/UnregisterPeekandhandle_(un)register_peek, and the MCP test case for SELECT becomesselect_not_vulnerable. The debug span and the debug logs that name these functions follow.mz_slow_message_handling{message_kind}:register-frontend-peekandunregister-frontend-peekbecomeregister-peekandunregister-peek.mz_catalog_snapshot_seconds{context}andmz_catalog_snapshot_cache{context}:try_frontend_peekbecomestry_peek.try_frontend_read_then_write(_with_cancel),frontend_read_then_write_applies,PeekClient::frontend_read_then_write(nowsession_read_then_write, next tobackground_read_then_write),FrontendWriteAttemptState,FrontendWriteCancellation, thetry_frontend_read_then_writecatalog-snapshot context and the tests named after them drop the prefix. The module keeps its name, next tocoord::read_then_write.@aljoscha, commit 4 renames your read-then-write code. Shout if you'd rather keep any of these names. Panel 110 of your "Frontend read-then-write" playground dashboard selects
context="try_frontend_read_then_write"and needs the new value."Frontend" stays where it still distinguishes something: statement logging (the coordinator keeps its own for the statements it sequences), the LaunchDarkly sync (
SystemParameterFrontend*), and pgwire'sFrontendMessage.🤖 Generated with Claude Code