fix(deps): bump urllib3 and PyJWT to clear 16 known CVEs - #65
Merged
Merged
Conversation
added 2 commits
October 3, 2026 06:07
KNOWN_ISSUES.md held 448 lines against a 300-line limit (rule R1), which blocked every commit on main. 224 of those lines were not board entries: 29 blocks injected verbatim from AGENT_DIARY.md by AutoDocUpdater during a full reindex, each carrying "Источник: AGENT_DIARY.md" and "Статус: автоматически синхронизировано". A board that mirrors the diary holds every issue twice and cannot be trimmed without losing information. The diary stays the source; the board keeps the 24 hand-authored sections. Live board is now 224 lines. scripts/archive_autosync_entries.py does this by marker rather than by date, so the classification does not rot as the file ages, and a second run finds nothing to move and changes nothing. Nothing is deleted — the blocks are appended to docs/archive/KNOWN_ISSUES_2026_10_AUTO_SYNC.md, per §4.8 R4.
pip-audit failed on both test jobs with vulnerabilities that appeared after the
last green main run on 2026-09-29, so this is a time-dependent failure rather
than a regression from any recent change:
urllib3 2.7.0 PYSEC-2026-4175 / -4176 / -4177 -> 2.8.0
PyJWT 2.13.0 13 advisories, highest fix 2.15.0 -> 2.15.0
Both are transitive: neither is imported as an API. PyJWT appears in the codebase
only as a token pattern in src/core/redact.py, and the line above the pin claimed
a verified RS256 roundtrip against pyjwt 2.13.0 — that claim is re-verified here
rather than assumed, and the comment is updated to the version actually tested.
Verified after the bump, not before:
- pip-audit -r requirements-lock.txt --no-deps --disable-pip -> "No known
vulnerabilities found", rc=0
- RS256 roundtrip with cryptography 50.0.0, and `import mcp` -> ok
- pytest tests/ -> 1989 passed, 6 skipped, 98 deselected
- scripts/smoke_e2e.py -> SMOKE E2E: PASSED, which exercises the real embed
(llama.cpp), the real rerank (BGE-M3) and a real index search, i.e. the
network stack urllib3 actually backs
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configuration
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
…y guard as UNPROVEN CI reported `NEGATIVE CONTROLS: FAILED (broken=0, unproven=1)` with `dead_guard_classifier` marked UNPROVEN — green locally, red on every runner. Root cause: tests/test_negative_controls_runner.py proved the digest pin by editing the REAL fixture scripts/negative_controls/fixtures/dead_guard.py and restoring it in `finally`. Under `pytest -n auto` another worker read that fixture's digest inside the window between the write and the restore, computed a different digest, and classified a healthy guard as UNPROVEN. The digest guard was never wrong; the race was between two tests, and it presented as a guard defect. Every digest matched locally and in a clean checkout, which is why this survived local verification — the trigger is worker count, not content. The test now copies the fixture into a scratch directory it creates and removes, and never touches the tracked file. It asserts a PROVEN control before mutating, so the property under test is still "a byte change flips PROVEN to UNPROVEN". Adds tests/test_no_tracked_file_mutation.py so the class cannot come back. It is a test rather than a script because a script nobody runs is not a gate, and its first version collected zero tests under pytest while reading as coverage. That guard's selftest earned its place immediately: it caught a real second instance in tests/test_planted_break_gate.py, which wrote experiments/planted_break/results.json from two xdist workers with no atomicity. That write is now temp-file + os.replace, the artifact is gitignored, and the one exemption is recorded with its reason. Verified: 1991 passed, 6 skipped, two consecutive runs of the exact CI command with -n auto.
ManSio
marked this pull request as ready for review
October 3, 2026 04:50
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.